[pyOpenSSL] version update #1431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
previously approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Thank you @goffi-contrib
Until we merge your other linter pull request, do you mind adding W504 to the tox.ini ignore list so the build is green? This rule changed recently. So if your pull request could also ignore it for now that would be awesome.
older version of pyOpenSSL was causing trouble ('module' object has no attribute 'OP_SINGLE_ECDH_USE'), updating it fixes it.
I didn't update to last version because OpenSSl and Cryptography are
outdated too, so this is a first step to have a working pyOpenSSL.
535f4b9 to
081261d
Compare
|
@AndreMiras sure, I've just updated the PR. Thanks for your quick feedbacks :) |
AndreMiras
reviewed
Oct 24, 2018
| @@ -18,4 +18,5 @@ ignore = | |||
| E123, E124, E126, | |||
| E226, | |||
| E402, E501, E722, | |||
| F812, F841, W503 | |||
| F812, F841, W503, | |||
| W504 | |||
There was a problem hiding this comment.
For later reference; We ignored W504 because the rule of flake8==3.5.0 became the anti-pattern in flake8==3.6.0.
See https://github.com/LintlyCI/Flake8Rules/blob/ed09f9d/_rules/W503.md
Note: Despite being in the best practice section, this will soon be considered an anti-pattern.
|
Sweet, let's see if CI is happy and merge it then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
older version of pyOpenSSL was causing trouble ('module' object has no attribute 'OP_SINGLE_ECDH_USE'), updating it fixes it.
I didn't update to last version because OpenSSl and Cryptography are
outdated too, so this is a first step to have a working pyOpenSSL.