[CORE FIX/ENHANCEMENT] Speedup copy that can be very very long (up to 2 minutes) #1585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now almost instant (1/2s.)
KeyWeeUsr
suggested changes
Jan 13, 2019
¡¡¡Thanks @KeyWeeUsr!!!
KeyWeeUsr
approved these changes
Jan 13, 2019
|
¡¡¡Thanks to merge this one @KeyWeeUsr, that will save time for all of us ❤️!!! ¡¡¡And also thanks to @tito ❤️ wich made this, all the credits for him...I'm only the messanger 😄!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the slow copy issue we have when copying files to our distribution folder and affects to python2 and python3.
I tested this in python 3 and @tito made and tested this commit in his own builds for python 2. Travis will say the final words but I suspect that we can reduce travis's build timings...will see...
@inclement please...take a look on this when you have time...this affects the core!
Again 😄, ¡¡¡Thanks @tito!!!