Fix bug in igraph recipe #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or a non-ARM achitecture. Also, get_platform.py was never really used. I thought I'd need to know exactly how distutils wanted me to write the architecture name, but I didn't really.
|
Please pull again, I fixed a bug |
| @@ -29,6 +29,8 @@ function shouldbuild_igraph() { | |||
|
|
|||
| function build_igraph() { | |||
| cd $BUILD_igraph | |||
| patch setup.py $RECIPE_igraph/setup.py.patch | |||
There was a problem hiding this comment.
normally, the patch is done is the prebuild phase, as the build be recalled later, so double-patch will not work. Do another PR for that please :)
|
In my testing, the prebuild phase never actually executed. Could I get some clarification on when it happens? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
igraph was failing to build when the build machine (x64) had its own igraph libraries. setup.py links against stuff in /usr/local/lib by default. Now I've patched it so it doesn't.