Skip to content

[WIP] New experimental argparse wrapper to have all options on all parsers #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[WIP] New experimental argparse wrapper to have all options on all parsers #1812

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 30, 2019

This is a new experimental argparse wrapper to have all options on all parsers. This might allow us to get rid of all the littered hasattr(args, "some_option") tests or getattr(args, "some_option", None) calls, such that always args.some_option can be used. I only removed a few instances of hasattr/getattr to test the functionality

@ghost ghost changed the title New experimental argparse wrapper to have all options on all parsers [WIP] New experimental argparse wrapper to have all options on all parsers Apr 30, 2019
@ghost ghost mentioned this pull request Apr 30, 2019
Merged
@ghost ghost requested a review from inclement April 30, 2019 22:52
@inclement inclement changed the base branch from master to develop June 6, 2019 20:40
@ghost ghost mentioned this pull request Aug 4, 2019
Merged
@kuzeyron kuzeyron added WIP core-providers Core code that's not a recipe labels Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inclement inclement Awaiting requested review from inclement

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
core-providers Core code that's not a recipe WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kuzeyron