make the virtual keyboard accept various languages #2015

gottadiveintopython · 2019-11-01T08:53:53Z

Currently, Japanese (and Chinese) keyboard doesn't show up on Android 9. (I don't know about other versions, but at least it does show up on Android 5.0.3). This PR fix it.

Please take a look at this discussion.

ghost · 2019-12-03T00:10:06Z

pythonforandroid/bootstraps/sdl2/build/src/main/java/org/libsdl/app/SDLActivity.java

@@ -2002,7 +2002,7 @@ public boolean onKeyPreIme (int keyCode, KeyEvent event) {
    public InputConnection onCreateInputConnection(EditorInfo outAttrs) {
        ic = new SDLInputConnection(this, true);

-        outAttrs.inputType = InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD;
+        outAttrs.inputType = InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_NORMAL;


Does TYPE_TEXT_VARIATION_NORMAL really have to be explicit? According to Android documentation, it is the default variation of TYPE_CLASS_TEXT.

Maybe, it doesn't have to be. I'll test it when I have time.

Considering that:

TYPE_CLASS_TEXT equals 1.

TYPE_TEXT_VARIATION_NORMAL equals 0.

Then 1 | 0 = 1, so I think it's a good idea to remove TYPE_TEXT_VARIATION_NORMAL:

Suggested change

outAttrs.inputType = InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_NORMAL;

outAttrs.inputType = InputType.TYPE_CLASS_TEXT;

By the way, keyboards with predictive text have a non-desirable behavior with this PR: written text (containing just letters) does not appear in TextInput. Only symbols, numbers, and text selected from suggested words are visible.

Test it and tell me if you can reproduce the bug, please. I'll try to fix it.

I can reproduce the bug.

I do not see any difference in behavior with or without TYPE_TEXT_VARIATION_NORMAL

When prediction is provided, the text does not appear in the TextInput until it is selected from the bar or "confirmed" with space character. Only some keyboard, like Swiftkey, selects the word on space character, others do not (Gboard?).
In most of the cases, on backspace, the text is first deleted from this invisible "buffer" and then from the TextInput.
Symbols and numbers behavior varies depending on a keyboard and whether the keyboard tries to predict numeric input.

Swipe on Swiftkey keyboard inserts the word twice, Gboard does not inserts anything (or inserts a space character? maybe it has something to do with the space character behavior)

ghost · 2019-12-05T23:38:32Z

pythonforandroid/bootstraps/sdl2/build/src/main/java/org/libsdl/app/SDLActivity.java

@@ -2002,7 +2002,7 @@ public boolean onKeyPreIme (int keyCode, KeyEvent event) {
    public InputConnection onCreateInputConnection(EditorInfo outAttrs) {
        ic = new SDLInputConnection(this, true);

-        outAttrs.inputType = InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD;
+        outAttrs.inputType = InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_NORMAL;


Considering that:

TYPE_CLASS_TEXT equals 1.

TYPE_TEXT_VARIATION_NORMAL equals 0.

Then 1 | 0 = 1, so I think it's a good idea to remove TYPE_TEXT_VARIATION_NORMAL:

Suggested change

outAttrs.inputType = InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_NORMAL;

outAttrs.inputType = InputType.TYPE_CLASS_TEXT;

By the way, keyboards with predictive text have a non-desirable behavior with this PR: written text (containing just letters) does not appear in TextInput. Only symbols, numbers, and text selected from suggested words are visible.

Test it and tell me if you can reproduce the bug, please. I'll try to fix it.

gottadiveintopython · 2019-12-08T14:39:38Z

keyboards with predictive text have a non-desirable behavior with this PR

I confirmed that. The cause probably is because TextInput doesn't listen to on_texteditevent. I ran the following code on Android:

from kivy.app import App
from kivy.lang import Builder
from kivy.factory import Factory

KV_CODE = '''
BoxLayout:
    TextInput:
    Button:
'''

class SampleApp(App):
    def build(self):
        return Builder.load_string(KV_CODE)
    def on_start(self):
        from kivy.core.window import Window
        Window.bind(
            on_textedit=lambda __, text: print('on_textedit:', text),
            on_textinput=lambda __, text: print('on_textinput:', text),
            )

if __name__ == '__main__':
    SampleApp().run()

I typed e. The text didn't appear but on_textedit: e was printed.
Then I typed r. The text still didn't appear but on_textedit: er was printed.
Then I selected error, one of suggestions. error appeared and on_textinput: error and on_textinput: were printed.

# over all prints
on_textedit: e
on_textedit: er
on_textinput: error
on_textinput:

If you look at the source, you can see there is no code that listening to on_textedit. Only on_textinput is listened to. That's why the text doesn't appear until the user finalize(commit) it.

So I believe TextInput needs quite change.

ghost · 2019-12-08T16:49:52Z

Nice! I tested it and, as you told, on_textedit is the responsible. I'll take a look on how to implement it on textinput.py and focus.py.

Also, I realised that with TYPE_CLASS_TEXT you can insert emojis, but after doing it, the app crashes with:

File "kivy/core/window/_window_sdl2.pyx", line 682, in kivy.core.window._window_sdl2._WindowSDL2Storage.poll
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xed in position 0: invalid continuation byte

I tried with multiple emojis and I always get the same error.

gottadiveintopython · 2019-12-08T17:24:54Z

Thanks. SDL_TEXTEDITING brings two arguments, which currently being ignored. That might be related to that error.
https://github.com/kivy/kivy/pull/6498/files
I'll test it tomorrow.

gottadiveintopython · 2019-12-12T08:08:40Z

@franccisco I can't reproduce the error. Emojis appear as tofu but no error. It might depends on the OS. Which version do you use? Mine is Fire OS 7, which derived from Android 9.

ghost · 2019-12-30T22:50:35Z

@gottadiveintopython Yes, it depends on the OS version. In older Android versions, the app crashes.

Well, there are two issues that needs fix at the moment: keyboard suggestions and emojis.

ghost · 2020-01-05T20:05:18Z

@gottadiveintopython The tofu you're watching is because the font used by Kivy (Roboto, unless you changed it) does not support emojis. There are some fonts that already do (I think Noto is useful in this case, as it supports emojis and is a font intended for all languages). As far as I know, Kivy only allows to register the regular, italic and bold variations of a font (https://github.com/kivy/kivy/blob/b1c643c8a6d3d4750dc2fa9a0232354dfcecd3a1/kivy/core/text/__init__.py#L291), so this file may need a modification too.

gottadiveintopython · 2020-02-03T21:17:39Z

close the pr due to #2057

Azag3077 · 2022-10-10T06:07:03Z

@gottadiveintopython The tofu you're watching is because the font used by Kivy (Roboto, unless you changed it) does not support emojis. There are some fonts that already do (I think Noto is useful in this case, as it supports emojis and is a font intended for all languages). As far as I know, Kivy only allows to register the regular, italic and bold variations of a font (https://github.com/kivy/kivy/blob/b1c643c8a6d3d4750dc2fa9a0232354dfcecd3a1/kivy/core/text/__init__.py#L291), so this file may need a modification too.
Hi....

Do you mean I have to register my downloaded font before I can use the emoji in it?

ghost reviewed Dec 3, 2019

View reviewed changes

ghost suggested changes Dec 5, 2019

View reviewed changes

ghost mentioned this pull request Dec 5, 2019

Auto-correct / word suggestion does not work with Swiftkey/Samsung keyboard #2010

Closed

make virtual keyboard accept various languages

b0657d9

This was referenced Jan 28, 2020

[WIP] Fix input type on android using SDL2 as window provider kivy/kivy#6716

Closed

Add keyboard input type customization for SDL2 #2057

Closed

gottadiveintopython closed this Feb 3, 2020

opacam mentioned this pull request Mar 28, 2020

🔥 Move to python3 super calls #2106

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

make the virtual keyboard accept various languages #2015

make the virtual keyboard accept various languages #2015

Uh oh!

gottadiveintopython commented Nov 1, 2019 •

edited

Loading

Uh oh!

ghost Dec 3, 2019

Uh oh!

gottadiveintopython Dec 5, 2019

Uh oh!

ghost Dec 5, 2019

Uh oh!

mjuchno Dec 7, 2019

Uh oh!

ghost Dec 5, 2019

Uh oh!

gottadiveintopython commented Dec 8, 2019 •

edited

Loading

Uh oh!

ghost commented Dec 8, 2019 •

edited by ghost

Loading

Uh oh!

gottadiveintopython commented Dec 8, 2019 •

edited

Loading

Uh oh!

gottadiveintopython commented Dec 12, 2019

Uh oh!

ghost commented Dec 30, 2019

Uh oh!

ghost commented Jan 5, 2020

Uh oh!

gottadiveintopython commented Feb 3, 2020

Uh oh!

Azag3077 commented Oct 10, 2022

Uh oh!

Uh oh!

	outAttrs.inputType = InputType.TYPE_CLASS_TEXT \| InputType.TYPE_TEXT_VARIATION_NORMAL;
	outAttrs.inputType = InputType.TYPE_CLASS_TEXT;

make the virtual keyboard accept various languages #2015

make the virtual keyboard accept various languages #2015

Uh oh!

Conversation

gottadiveintopython commented Nov 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost Dec 3, 2019

Choose a reason for hiding this comment

Uh oh!

gottadiveintopython Dec 5, 2019

Choose a reason for hiding this comment

Uh oh!

ghost Dec 5, 2019

Choose a reason for hiding this comment

Uh oh!

mjuchno Dec 7, 2019

Choose a reason for hiding this comment

Uh oh!

ghost Dec 5, 2019

Choose a reason for hiding this comment

Uh oh!

gottadiveintopython commented Dec 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Dec 8, 2019 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gottadiveintopython commented Dec 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gottadiveintopython commented Dec 12, 2019

Uh oh!

ghost commented Dec 30, 2019

Uh oh!

ghost commented Jan 5, 2020

Uh oh!

gottadiveintopython commented Feb 3, 2020

Uh oh!

Azag3077 commented Oct 10, 2022

Uh oh!

Uh oh!

gottadiveintopython commented Nov 1, 2019 •

edited

Loading

gottadiveintopython commented Dec 8, 2019 •

edited

Loading

ghost commented Dec 8, 2019 •

edited by ghost

Loading

gottadiveintopython commented Dec 8, 2019 •

edited

Loading