-
Notifications
You must be signed in to change notification settings - Fork 1.9k
update pyproj recipe #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update pyproj recipe #2017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
As another improvement I would suggest to use the {version}
tag rather overriding.
Also please squash to one commit if you know how to, otherwise we would do it on merge time if the build turns green
4b155fa
to
40fe43e
Compare
40fe43e
to
53adfd5
Compare
Sorry for force pushing again, there still was a typo in the url (missing |
Ahah no prob. Could you rebase on develop since I've merge the CI fix. That way we'll all see if your PR builds ok |
53adfd5
to
b5290df
Compare
b5290df
to
139c778
Compare
Thanks for rebasing!
Full log https://travis-ci.org/kivy/python-for-android/jobs/609959438 |
Yes, this is strange, why would setuptools not be installed? FYI, I managed to build my app on travis using the proposed recipe change:
EditI just realized, that the build logs were cached away by travis, here is the build log from my local machine. Here is the excerpt related to the pyproj build:
|
Thank you @joergbrech for looking into it and sharing the logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The build was fixed by @opacam via.
I've tried your PR locally and I'm confident it should just fine after merging
bumps pyproj version to 1.9.6 and fixes the source url. Previously the url pointed to the latest pyproj version, which
hostpython3