Skip to content

Fix missing renames of Bootstrap.list_bootstraps -> Bootstrap.all_bootstraps #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2020
Merged

Fix missing renames of Bootstrap.list_bootstraps -> Bootstrap.all_bootstraps #2066

merged 1 commit into from
Feb 21, 2020

Conversation

touilleMan
Copy link
Contributor

@touilleMan touilleMan commented Feb 21, 2020 •
edited
Loading

Fixes p4a bootstrap command:

$ p4a bootstraps
Traceback (most recent call last):
  File "/home/touilleman/projects/buildozer-test/venv/bin/p4a", line 10, in <module>
    sys.exit(main())
  File "/home/touilleman/projects/buildozer-test/venv/lib/python3.7/site-packages/pythonforandroid/entrypoints.py", line 18, in main
    ToolchainCL()
  File "/home/touilleman/projects/buildozer-test/venv/lib/python3.7/site-packages/pythonforandroid/toolchain.py", line 671, in __init__
    getattr(self, args.subparser_name.replace('-', '_'))(args)
  File "/home/touilleman/projects/buildozer-test/venv/lib/python3.7/site-packages/pythonforandroid/toolchain.py", line 788, in bootstraps
    for bs in Bootstrap.list_bootstraps():
AttributeError: type object 'Bootstrap' has no attribute 'list_bootstraps'

@opacam
Copy link
Member

opacam commented Feb 21, 2020

Thanks!! 😄,

Do you mind to rename as well this list_bootstraps entry 😬?

opacam
opacam previously approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Note: it would be awesome if we could change the docstring I mentioned before in this PR, so we could have all the renames of list_boostraps concentrated at same PR.

@touilleMan touilleMan force-pushed the fix-Bootstrap.all_bootstraps-use branch from a16cd60 to e6be47a Compare February 21, 2020 12:45
@touilleMan
Copy link
Contributor Author

@opacam I've update my PR to correct the docstring ;-)

opacam
opacam approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thanks again!!! 😄

@opacam opacam merged commit 8740267 into kivy:develop Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opacam opacam opacam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@touilleMan @opacam