Skip to content

[gh-actions] Move to actions/checkout@v2 #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2020
Merged

[gh-actions] Move to actions/checkout@v2 #2070

merged 2 commits into from
Feb 24, 2020

Conversation

opacam
Copy link
Member

@opacam opacam commented Feb 24, 2020

To fix gh-actions failures on re-running checks, like the one we have at here for #2069

@AndreMiras
Copy link
Member

It seems like we get a regression on the rebuild_updated_recipes.

ANDROID_SDK_HOME=/home/user/.android/android-sdk ANDROID_NDK_HOME=/home/user/.android/android-ndk \
venv/bin/python ci/rebuild_updated_recipes.py
Traceback (most recent call last):
  File "ci/rebuild_updated_recipes.py", line 112, in <module>
    main()
  File "ci/rebuild_updated_recipes.py", line 77, in main
    recipes = modified_recipes()
  File "ci/rebuild_updated_recipes.py", line 43, in modified_recipes
    git_diff = sh.contrib.git.diff('--name-only', branch)
  File "/home/user/app/venv/lib/python3.6/site-packages/sh.py", line 1427, in __call__
    return RunningCommand(cmd, call_args, stdin, stdout, stderr)
  File "/home/user/app/venv/lib/python3.6/site-packages/sh.py", line 774, in __init__
    self.wait()
  File "/home/user/app/venv/lib/python3.6/site-packages/sh.py", line 792, in wait
    self.handle_command_exit_code(exit_code)
  File "/home/user/app/venv/lib/python3.6/site-packages/sh.py", line 815, in handle_command_exit_code
    raise exc
sh.ErrorReturnCode_128: 

  RAN: /usr/bin/git diff --name-only origin/develop

@opacam
[gh-actions] Checkout develop branch for rebuild_updated_recipes
2c0709c 
Since we make use of `git diff` command at `rebuild_updated_recipes`
(against develop branch), we also need to checkout develop branch to
success with our script.
AndreMiras
AndreMiras approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opacam opacam merged commit c0a30ea into kivy:develop Feb 24, 2020
@opacam opacam mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opacam @AndreMiras