✨ Compression libraries - episode III: add support for libbz2 & liblzma to python3 #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
previously approved these changes
Mar 24, 2020
| .. note:: This recipe can be built only against API 21+. Also, in order to | ||
| build certain python modules, we need to add some extra recipes to our | ||
| build requirements: | ||
| The python 3 recipe can be built with some extra python modules, but do so, |
| build certain python modules, we need to add some extra recipes to our | ||
| build requirements: | ||
| The python 3 recipe can be built with some extra python modules, but do so, | ||
| we need some libraries. Per default, we ship the python3 recipe with some |
| build requirements: | ||
| The python 3 recipe can be built with some extra python modules, but do so, | ||
| we need some libraries. Per default, we ship the python3 recipe with some | ||
| common libraries, defined at ``depends``.We also support some optional |
There was a problem hiding this comment.
I would say defined in but I suck at grammar. Also missing a space between the dot and "We"
There was a problem hiding this comment.
I'm not sure about this but what I'm sure is that your English is a lot better than mine...so let's go for in, thanks!!! 😄
| The python 3 recipe can be built with some extra python modules, but do so, | ||
| we need some libraries. Per default, we ship the python3 recipe with some | ||
| common libraries, defined at ``depends``.We also support some optional | ||
| libraries, which are less common that the ones defined at ``depends``, so |
0bbb62b to
1117908
Compare
AndreMiras
approved these changes
Mar 24, 2020
zworkb
pushed a commit
to zworkb/python-for-android
that referenced
this pull request
Apr 15, 2020
…ma to python3 (kivy#2097) * ✨ Add `bz2` and `lzma` support to `Python3` * 📝 Update python3 recipe docstrings * 📝 Fix typos and grammar errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third part and last of a set of recipes that will add add support for libbz2 & liblzma to python3 recipe, allowing us to build some extra python modules:
_bz2.cpython-38.so_lzma.cpython-38.soAlso I put up-to-date the python3 recipe documentation 📝
These libraries are required by some python packages, like
pandas, which I plan to create a PR later 😉Notes:
on_device_unit_test_app#2046 - Episode II #2088Compression libraries...: ✨ Compression libraries - episode I: libbz2 #2095 and ✨ Compression libraries - episode II: liblzma #2096