Skip to content

🔥 Move to python3 super calls #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2020
Merged

🔥 Move to python3 super calls #2106

merged 2 commits into from
Mar 30, 2020

Conversation

opacam
Copy link
Member

@opacam opacam commented Mar 28, 2020

No description provided.

AndreMiras
AndreMiras previously approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@opacam
Copy link
Member Author

opacam commented Mar 28, 2020 •
edited
Loading

BTW, I made this after #2105, so I recommend to merge it after that. You can see the tox error complaining about python2 entry point test...anyhow once we have that merged we should be fine

@opacam opacam mentioned this pull request Mar 28, 2020
Merged
inclement
inclement previously approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also approving, pending #2105 merge.

@inclement inclement dismissed stale reviews from AndreMiras and themself via 5046538 March 30, 2020 13:10
inclement
inclement approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved pending tests passing to confirm my merge conflicts fix worked.

@inclement inclement merged commit e02541f into kivy:develop Mar 30, 2020
@inclement
Copy link
Member

Thanks!

@opacam opacam deleted the feature-python3-super branch March 30, 2020 22:20
zworkb pushed a commit to zworkb/python-for-android that referenced this pull request Apr 15, 2020
@opacam @inclement @zworkb
🔥 Move to python3 super calls (kivy#2106)
e898440 
Co-authored-by: Alexander Taylor <alexanderjohntaylor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inclement inclement inclement approved these changes

@AndreMiras AndreMiras AndreMiras left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@opacam @inclement @AndreMiras