Fix coveralls error on GitHub Actions #2129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coveralls started failing suddenly in GitHub Actions Worflows. This feels like a bug on their side (at least their documentation) because the `CI` environment variable is not supposed to be set refs: https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables#default-environment-variables Disabling the `coveralls` conditional run from the `Makefile` fixes it. It wasn't needed as Travis already calls it explicitly without going through the `test` target. Error was: ``` /bin/sh: 1: .tox/py36/bin/coveralls: not found Makefile:30: recipe for target 'test' failed make: *** [test] Error 127 ```
inclement
approved these changes
Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coveralls started failing suddenly in GitHub Actions Worflows.
This feels like a bug on their side (at least their documentation)
because the
CIenvironment variable is not supposed to be set refs:https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables#default-environment-variables
Disabling the
coverallsconditional run from theMakefilefixes it.It wasn't needed as Travis already calls it explicitly without going
through the
testtarget.Error was: