Skip to content

Bumps cffi==1.13.2 fixes under Python 3.8 #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2020
Merged

Bumps cffi==1.13.2 fixes under Python 3.8 #2131

merged 1 commit into from
Apr 4, 2020

Conversation

AndreMiras
Copy link
Member

@AndreMiras AndreMiras commented Apr 4, 2020 •
edited
Loading

@AndreMiras
Bumps cffi==1.13.2 fixes under Python 3.8
10cf158 
https://bitbucket.org/cffi/cffi/issues/403/build-fails-on-38-dev-pyinterpreterstate
kivy#2130 (comment)
The error was:
```
c/call_python.c:20:30: error: incomplete definition of type 'struct _is'
```
@AndreMiras
Copy link
Member Author

I didn't dare to bump it to cffi==1.14.0 because it got released too recently. Also 1.13.2 is the version I've used for a while under Python 3.7 and I know it's working correctly

@inclement
Copy link
Member

Thanks!

@inclement inclement merged commit d56181c into kivy:develop Apr 4, 2020
@AndreMiras AndreMiras deleted the feature/cffi_version_bump branch April 4, 2020 19:37
@opacam opacam mentioned this pull request Apr 10, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inclement inclement inclement approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreMiras @inclement @brvier