Skip to content

Add Recipe for Kivy3 module #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2020
Merged

Add Recipe for Kivy3 module #2263

merged 3 commits into from
Jul 19, 2020

Conversation

excepterror
Copy link
Contributor

@excepterror excepterror commented Jul 17, 2020

Adding the kivy3 module in the requirements in .spec file results to the installation of the module via pip during the debug process. However, the default.glsl file is not copied to the python-installs directory and, subsequently, to the distributions folder. This recipe remedies the issue.

I created this pull-request following @inclement 's advice on discord. Thanks.

@excepterror excepterror changed the title Create Recipe for Kivy3 module Add Recipe for Kivy3 module Jul 17, 2020
Co-authored-by: Andre Miras <AndreMiras@users.noreply.github.com>
@excepterror
Copy link
Contributor Author

@AndreMiras
Travis build still fails :)
Thanks for reviewing the recipe, by the way!

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!
Yes the sqlite download has been failing in macOS lately, I'm not too sure why.
I've tried multiple times and the download is working locally. The file is https://www.sqlite.org/2016/sqlite-amalgamation-3150100.zip
I'm OK to ignore for now and go ahead with the merge since it's not related to your changes

@AndreMiras AndreMiras merged commit 4db3116 into kivy:develop Jul 19, 2020
@excepterror
Copy link
Contributor Author

Great news! Glad for this tiny contribution!

vesellov pushed a commit to vesellov/python-for-android that referenced this pull request Feb 10, 2021
germn pushed a commit to germn/python-for-android that referenced this pull request Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants