Skip to content

android: call non-static methods on .mActivity #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2020
Merged

android: call non-static methods on .mActivity #2341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pythonforandroid/recipes/android/src/android/loadingscreen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@


def hide_loading_screen():
python_activity = autoclass(ACTIVITY_CLASS_NAME)
python_activity.removeLoadingScreen()
mActivity = autoclass(ACTIVITY_CLASS_NAME).mActivity
mActivity.removeLoadingScreen()
14 changes: 7 additions & 7 deletions pythonforandroid/recipes/android/src/android/permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,8 +487,8 @@ class _RequestPermissionsManager:
def register_callback(cls):
"""Register Java callback for requestPermissions."""
cls._java_callback = _onRequestPermissionsCallback(cls.python_callback)
python_activity = autoclass(ACTIVITY_CLASS_NAME)
python_activity.addPermissionsCallback(cls._java_callback)
mActivity = autoclass(ACTIVITY_CLASS_NAME).mActivity
mActivity.addPermissionsCallback(cls._java_callback)

@classmethod
def request_permissions(cls, permissions, callback=None):
Expand All @@ -511,12 +511,12 @@ def request_permissions(cls, permissions, callback=None):
with cls._lock:
if not cls._java_callback:
cls.register_callback()
python_activity = autoclass(ACTIVITY_CLASS_NAME)
mActivity = autoclass(ACTIVITY_CLASS_NAME).mActivity
if not callback:
python_activity.requestPermissions(permissions)
mActivity.requestPermissions(permissions)
else:
cls._callback_id += 1
python_activity.requestPermissionsWithRequestCode(
mActivity.requestPermissionsWithRequestCode(
permissions, cls._callback_id)
cls._callbacks[cls._callback_id] = callback

Expand Down Expand Up @@ -586,8 +586,8 @@ def check_permission(permission):
Returns:
bool: True if the app holds the permission given, False otherwise.
"""
python_activity = autoclass(ACTIVITY_CLASS_NAME)
result = bool(python_activity.checkCurrentPermission(
mActivity = autoclass(ACTIVITY_CLASS_NAME).mActivity
result = bool(mActivity.checkCurrentPermission(
permission + ""
))
return result