Skip to content

update sqlite3 #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2021
Merged

update sqlite3 #2449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pythonforandroid/recipes/sqlite3/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@


class Sqlite3Recipe(NDKRecipe):
version = '3.34.1'
version = '3.35.5'
# Don't forget to change the URL when changing the version
url = 'https://www.sqlite.org/2021/sqlite-amalgamation-3340100.zip'
url = 'https://www.sqlite.org/2021/sqlite-amalgamation-3350500.zip'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it was already not working in the past, but ideally the url should be built from the version.
I think the PR is good enough, but we could follow up on that.
I think overriding the versioned_url() method should do the trick

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The year in the url isn't something we can derive from the version though :(

https://www.sqlite.org/2021/sqlite-amalgamation-3350500.zip
                       ^^^^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that 😞

generated_libraries = ['sqlite3']

def should_build(self, arch):
Expand Down