Adds libm to Pillow recipe #2465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have put requirements=pillow directly without any modification .buildozer/android/platform/python-for-android/pythonforandroid/recipes/Pillow/init.py Results In Android 8 running well without any problem In Android 5 crashing ImportError: dlopen failed: cannot locate symbol "log" referenced by "_imaging.so"... and after the change ,In both device running well. env['CFLAGS'] += cflags + " -lm"
AndreMiras
requested changes
Jun 17, 2021
There was a problem hiding this comment.
Thank you for the investigation and fix.
Added a comment if you could address.
Also I wish we had a more meaningful commit title.
Maybe you could change it to "Adds libm to Pillow recipe" or something.
You can edit the commit message with:
git commit --amend "Adds libm to Pillow recipe"
git push --force
If you know how to squash commit, ideally try to since it's a small diff.
To squash you can simply make the edit of the file and then:
```sh
git add pythonforandroid/recipes/Pillow/__init__.py
git commit --amend
git push --forceOtherwise I'll try to think about it upon merge
|
please merge it .other wise kivymd user will face problem with old android device . |
Don't know if it's related, but I'm having trouble compiling Pillow - https://discord.com/channels/423249981340778496/678695971164520523/854086968781307985 |
AndreMiras
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kivy/buildozer#1020
I have put requirements=pillow directly without any modification
.buildozer/android/platform/python-for-android/pythonforandroid/recipes/Pillow/init.py
Results
In Android 8 running well without any problem
In Android 5 crashing
ImportError: dlopen failed: cannot locate symbol "log" referenced by "_imaging.so"...
and after the change ,In both device running well.
env['CFLAGS'] += cflags + " -lm"