Skip to content

Fix issue #2630 #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2022
Merged

Fix issue #2630 #2631

merged 3 commits into from
Jul 9, 2022

Conversation

Neizvestnyj
Copy link
Contributor

Now, if the requirements has not been changed, the reassembly will not occur

@mzakharo
Copy link
Contributor

the fix does not make sense to me. install_in_hostpython = True is a directive to build the recipe twice, once for target arch, and once for host arch. You would only need to build for hostpython if some other recipe has a build dependency on tflite-runtime, which to my knowledge, is not the cause of issue #2630.

Many recipes dont have this 'install_in_hostpython' directive, and do not exhibit issue #2630 .

Am I missing something?

@Neizvestnyj
Copy link
Contributor Author

the fix does not make sense to me. install_in_hostpython = True is a directive to build the recipe twice, once for target arch, and once for host arch. You would only need to build for hostpython if some other recipe has a build dependency on tflite-runtime, which to my knowledge, is not the cause of issue #2630.

Many recipes dont have this 'install_in_hostpython' directive, and do not exhibit issue #2630 .

Am I missing something?

It's really strange, but you can check if for some reason the package stops being reassembled

@AndreMiras
Copy link
Member

Agree, what should be looked into instead is probably the PythonRecipe.should_build().
You can override this function in your recipe, put a breakpoint and step into super().should_build(arch).
My guess would be there's some kind of mismatch between the recipe name and what's to be expected in that folder, well something like that.
But that requires a bit of digging

@Neizvestnyj
Copy link
Contributor Author

Agree, what should be looked into instead is probably the PythonRecipe.should_build(). You can override this function in your recipe, put a breakpoint and step into super().should_build(arch). My guess would be there's some kind of mismatch between the recipe name and what's to be expected in that folder, well something like that. But that requires a bit of digging

Done

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Neizvestnyj

Seems that the PEP8 tests are failing (and so also the other tests), can you take care of it?

@Neizvestnyj Neizvestnyj requested a review from misl6 July 6, 2022 20:32
@Neizvestnyj
Copy link
Contributor Author

Hi @Neizvestnyj

Seems that the PEP8 tests are failing (and so also the other tests), can you take care of it?

Done

@tshirtman tshirtman merged commit 6fa6dde into kivy:develop Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants