Correct check for --sdk option #2870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message "WARNING: Received a --sdk argument, but this argument is deprecated and does nothing." was displayed even if no --sdk option was passed.
This appears to be the history:
The default value of the argument is -1, so we should issue a warning only if the value has been changed (i.e. by supplying a value) and then we should set the value to -1 to make sure it isn't used.
[Alternatively, accept that no-one is still using this option, and delete the check.]