update: numpy, pandas, sdl2
#3164
Conversation
40f08b6 to
a09a2b3
Compare
1cd30ca to
edea820
Compare
|
Ready for review. Hope it can be merged soon! (One action failed, probably due to an internet connection error) |
|
@AndreMiras any updates on this? |
There was a problem hiding this comment.
Yeah thanks for addressing the site package exclude thingy in a different way, at least now it doesn't impact all the other recipes.
However, generally speaking I'm cautious with changes in the core code that introduce a bit more complexity specially if it's for some very rare cases, I hope you understand.
While the changes in download_if_necessary() are easy to grasp and could easily help for more than a couple of recipes, I still want to believe we could try a different approach for the site package exclude dir exception case.
Maybe addressing it from within the Numpy recipe wouldn't be the sexiest, but at least it would be more contained.
Would you mind giving this specific part an extra thought otherwise I can give it a try when I get a chance.
This might as well not be easy at all or would in fact introduce much more complexity and completely off balance the benefits. I haven't explored, but it might be worth thinking about it and giving it a try.
Edit: my naive thought on that one is to Recipe.get_recipe('python3', self.ctx) from numpy prebuild_arch() to then mutate site_packages_dir_blacklist there. It's definitely hacky, but much more contained.
Also if @misl6 thinks otherwise, I totally trust him to make the right call, he's much more active and knowledgeable that anyone else regarding this code base
calls: def load_source(module, filename):
# Python 3.5+
import importlib.util
if hasattr(importlib.util, 'module_from_spec'):
spec = importlib.util.spec_from_file_location(module, filename)
mod = importlib.util.module_from_spec(spec)
spec.loader.exec_module(mod)
return mod
else:
# Python 3.3 and 3.4:
from importlib.machinery import SourceFileLoader
return SourceFileLoader(module, filename).load_module()However, this dynamic loading of the python3 recipe does not affect as site_packages_dir = self.ctx.python_recipe.create_python_bundle(
join(self.dist_dir, python_bundle_dir), arch)Edit: My opinion, it's fine as it is :) |
Closes #3163
Split #3136