Replace hardcoded "-jX" for make #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just added now -j$MAKE_JOBS to all make commands (untested but beleave it works) and replaced all hardcoded -jX options with -j$MAKE_JOBS |
| @@ -93,6 +93,11 @@ case $OSTYPE in | |||
| ;; | |||
| esac | |||
|
|
|||
| if [ -f /proc/cpuinfo ]; then | |||
There was a problem hiding this comment.
Maybe this should check if MAKE_JOBS is already set, so you can tell it how many jobs to use? Like if [ -z "$MAKE_JOBS" -a -f /proc/cpuinfo ]; then ...
There was a problem hiding this comment.
Didn't think about this situation. I'm not so good in bash just found a variation of this on the web and rewritten it.
Would it be a problem to merge the PR and you could make this tweak?
inclement
added a commit
that referenced
this pull request
Oct 3, 2015
Replace hardcoded "-jX" for make
|
I guess the only reason this wasn't merged was kived's observation, but it still seems like an improvement so I'll merge it anyway. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that "make -j5" was set globally when push_arm was done.
There might be other places were -j5 is missing now but I think they can be fixed very quickly.