At one point I started out to factor out the common stuff using a build.py jinja2 template, but eventually decided it wasn't actually worth it since it seemed either very fiddly (factoring out in a fine grained way) or not really doing much (just factoring it into large blocks that were mostly duplicated anyway). I'm happy to do it if someone wants to, but it made me think it's not a priority, unless maybe we somehow get several very similar bootstraps.

Anyway, seems good, I'll check it later.

It seems you don't actually use the --permissions optio for anything, so they can be specified but are ignored. Is this correct?

Incorrect. The --permissions options are rendered in AndroidManifest.xml.tmpl, and must be specified if any Android permissions are required. I made this PR because, to get Twisted to run, the INTERNET permission was required.

Oh, okay, I didn't remember copying it. Thanks.

On 02/10/15 00:21, str4d wrote:

Incorrect. The |--permissions| options are rendered
https://github.com/str4d/python-for-android/blob/permissions/pythonforandroid/bootstraps/sdl2/build/build.py#L262
in |AndroidManifest.xml.tmpl|
https://github.com/str4d/python-for-android/blob/permissions/pythonforandroid/bootstraps/sdl2/build/templates/AndroidManifest.xml.tmpl,
and must be specified if any Android permissions are required. I made
this PR because, to get Twisted to run, the |INTERNET| permission was
required.

—
Reply to this email directly or view it on GitHub
#458 (comment).

Yeah, the code to use permissions is all there, all that was missing from SDL2 was the command-line arguments.

Super then, thanks.