Skip to content

Recipes #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2015
Merged

Recipes #459

merged 2 commits into from
Oct 31, 2015

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Sep 15, 2015

More recipes. All recipes appear to build correctly (except maybe pyOpenSSL), but for some reason, the OpenSSL recipe causes problems in SDL2:

$ ANDROIDSDK=/home/str4d/dev/android/sdk ANDROIDAPI=19 ANDROIDNDK=/home/str4d/dev/android/android-ndk-r10e p4a apk --private /src/ --package org.example.recipestest --name "Hello Recipes" --version 1.0 --requirements sdl2,openssl --dist_name recipes --debug
...
[DEBUG]:    /home/str4d/dev/android/android-ndk-r10e/toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc -MMD -MP -MF /home/str4d/.local/share/python-for-android/build/bootstrap_builds/sdl2/obj/local/armeabi/objs/main/start.o.d -fpic -ffunction-sections -funwind-tables -fstack-protector -no-canonical-prefixes -march=armv5te -mtune=xscale -msoft-float -mthumb -Os -g -DNDEBUG -fomit-frame-pointer -fno-strict-aliasing -finline-limit=64 -I/home/str4d/.local/share/python-for-android/build/bootstrap_builds/sdl2/jni/src/../SDL/include -I/home/str4d/.local/share/python-for-android/build/bootstrap_builds/sdl2/jni/SDL/include -I/home/str4d/.local/share/python-for-android/build/bootstrap_builds/sdl2/jni/src -DANDROID -I/home/str4d/.local/share/python-for-android/build/bootstrap_builds/sdl2/jni/src/../../../../other_builds/python2/armeabi/python2/python-install/include/python2.7 -Wa,--noexecstack -Wformat -Werror=format-security    -I/home/str4d/dev/android/android-ndk-r10e/platforms/android-19/arch-arm/usr/include -c  /home/str4d/.local/share/python-for-android/build/bootstrap_builds/sdl2/jni/src/start.c -o /home/str4d/.local/share/python-for-android/build/bootstrap_builds/sdl2/obj/local/armeabi/objs/main/start.o
[DEBUG]:    /home/str4d/.local/share/python-for-android/build/bootstrap_builds/sdl2/jni/src/start.c:3:20: fatal error: Python.h: No such file or directory
[DEBUG]:     #include "Python.h"
[DEBUG]:                        ^
[DEBUG]:    compilation terminated.
[DEBUG]:    /home/str4d/dev/android/android-ndk-r10e/build/core/build-binary.mk:464: recipe for target '/home/str4d/.local/share/python-for-android/build/bootstrap_builds/sdl2/obj/local/armeabi/objs/main/start.o' failed
[DEBUG]:    make: *** [/home/str4d/.local/share/python-for-android/build/bootstrap_builds/sdl2/obj/local/armeabi/objs/main/start.o] Error 1

The problem remains even if I remove the modification to the Python2 recipe (so therefore the OpenSSL recipe should be completely independent of the SDL2 one). However, if I run a build that does not contain --requirements openssl (or anything with a dependency on it) then the SDL2 recipe builds fine even with the Python2 recipe modifications.

@inclement
Copy link
Member

Great, thanks. Do the pypi ones definitely need recipes? I know they do in p4a master, but I'm not sure why they can't be installed by pip.

@str4d
Copy link
Contributor Author

str4d commented Sep 15, 2015

They shouldn't need recipes (I'm running a test now to check), but currently any recipe that wants to depend on them will require them. The Twisted app I want to get running depends on all of the above.

@inclement
Copy link
Member

Okay, makes sense.

@str4d
Copy link
Contributor Author

str4d commented Sep 15, 2015

IMHO if #449 is an easy fix, then we don't bother checking in the trivial recipes (and I'll remove the first commit from the PR). If it isn't, then we check them in for now and then drop them once they aren't necessary (and existing dependent recipes will not be affected, because the recipe names are the same as their PyPI names).

@str4d
Copy link
Contributor Author

str4d commented Sep 15, 2015

And for the record, all three trivial recipes (enum34, six and pyasn1) work when installed by pip - inasmuch as they do get copied into assets/private.mp3.

@inclement
Copy link
Member

I won't let these recipes hold me up checking and merging the PRs, but indeed if it's an easy fix then I'l do it first and just remove them. Thanks though - as tito remarked when he did kivy-ios, redoing all the recipes is an annoying part!

@str4d
Copy link
Contributor Author

str4d commented Sep 15, 2015

I'm happy to get the various recipes relevant to me into a state as close to working as I can, which should make your job easier (only having to spot my stupid mistakes 😛), and provide additional data points for testing the toolchain 😄 For now I'll stick to recipes I need that I think are generally helpful, since all recipes currently need to be in the core codebase until support for user-defined recipes is ready.

@inclement inclement removed the revamp label Oct 5, 2015
inclement added a commit that referenced this pull request Oct 31, 2015
@inclement
Merge pull request #459 from str4d/recipes
ceb5df6 
Recipes
@inclement inclement merged commit ceb5df6 into kivy:revamp Oct 31, 2015
@inclement
Copy link
Member

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@str4d @inclement