Skip to content

Added audiostream recipe #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2015
Merged

Added audiostream recipe #508

merged 3 commits into from
Dec 5, 2015

Conversation

hottwaj
Copy link
Contributor

@hottwaj hottwaj commented Dec 5, 2015

I've included code to allow either sdl or sdl2 dependency.

However the library itself only links against SDL1 at the moment - the library needs to be changed to know when it is being linked against SDL2 (library names to link are slightly different)

@inclement
Copy link
Member

Nice, thanks. Could you make the recipe actually fail (I guess print a message and throw an exception or just exit()) if it's built with sdl2, to make it clear to the user what the problem is? I think that would be the best way for now.

@hottwaj
Copy link
Contributor Author

hottwaj commented Dec 5, 2015

Sure - just added that. Do you know of a way of passing an option to setup.py (distutils) so that we can tell audiostream whether to do an SDL or SDL2 link? If there is a mechanism for passing that info I can get the SDL2 route finished off. Thanks!

@inclement
Copy link
Member

Thanks, merged.

I'm not sure what's the best way to pass things to setup.py. One option is an environment variable (and to modify the setup.py to check it) - this is what e.g. kivy does. A cruder option is what I did with pyjnius, to add a patch that changes the behaviour, but this is less desirable.

inclement added a commit that referenced this pull request Dec 5, 2015
Added audiostream recipe
@inclement inclement merged commit 38db03e into kivy:master Dec 5, 2015
@hottwaj
Copy link
Contributor Author

hottwaj commented Dec 5, 2015

OK thanks, an environment variable would pretty easy to set up.

I'll add that in when I get back to testing what I'm working on with the sdl2 bootstrap.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants