Distribute.sh doesnt work properly with python3 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why you closed the request, if it works for all python >= 2.6, it's a nice imporvement :) |
|
i decided to test it a little bit more before reopening. but i don't know why i'm having some problems to create a distribution (kivy/cython stuff), it's not related to my changes but I can't test if the whole process will really work with python3. anyway reopening it... maybe someone can test and confirm it's working. |
|
Actually, i think if you have python3 as default, some things will not work: we are compiling an hostpython 2.7, so we must use it everywhere. BUT, in some case, like cython, it will generate code that doesn't work on 2.7 (it happened to me one time :/). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, if the 'python' executable points to python3 then distribute.sh will not work properly. This pull request will work for python >= 2.6