introduce versioning for openssl #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without versioning m2crypto failed to load on Android 5.1.1 and lower. |
|
Looks good, thanks. Do you know why this wasn't happening before, is the system openssl a new addition? |
|
It appears that unknowingly the system openssl was being used and cyanogenmod has a newer version installed than stock. I discovered this when the specific missing symbol turned out to be a new addition going from 1.0.1.l to 1.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android versions lower than 6.0 the openssl library of the system is being loaded instead of the one provided with the app.
Adding the version to the name of the shared library file avoids the problem of the linker at runtime giving the wrong version of the library and provides a clear indication of what version you are using (good ensuring you use the latest version for security).