forked from typescript-eslint/typescript-eslint
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] main from typescript-eslint:main #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
2,257
commits into
kkpan11:main
Choose a base branch
from
typescript-eslint:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+334,753
−595,846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix or suggestion (#10701) feat : separate the button text whether it is a fix and suggestion
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…pes (#10638) * fix(eslint-plugin): [no-duplicate-type-constituents] handle nested types * fix * Update no-duplicate-type-constituents.ts * fix naming
…ays of using module augmentation (#10616) * remove unnecessary checks so the rule correctly doesn't report on the various ways to have augmented modules * add tests for exported interface and non-exported type alias declaration --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
…0678) * fix : handle accessor keyword * test: change test code * test : add invalid case * fix : apply for abstract class
…roperty that is mutated in the constructor (#10552) * initial implementation * add tests * verify the about-to-be-added type annotation is in-scope * auto fix only literals that have been modified in the class constructor
…ate literal type (#10612) * fix(eslint-plugin): handle expressions in template literal type * Update no-unnecessary-template-expression.test.ts * add docs * update snapshots * handle undefined & null * add tests * add tests * apply review * apply reviews * add comments
…ons (#10588) * add docs around verbatimModuleSyntax * improve no-require-imports docs * Update docs/troubleshooting/faqs/TypeScript.mdx Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> * Update packages/eslint-plugin/docs/rules/no-require-imports.mdx Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> * Update docs/troubleshooting/faqs/TypeScript.mdx Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> * some feedback * Update docs/troubleshooting/faqs/TypeScript.mdx Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> * Update packages/eslint-plugin/docs/rules/no-namespace.mdx Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> * Update docs/troubleshooting/faqs/TypeScript.mdx Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> * review feedback * tweak * typescript * Update packages/eslint-plugin/docs/rules/no-require-imports.mdx Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> * correct broken link in consistent-type-imports.mdx --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
…ult-export and named-export nodes (#10685) add strict parent types for function declaration and export named/default nodes
…donly class properties with a literal initializer (#10618) * fix: handle readonly class properties * test: add test * test: add valid case * fix: check that template literals nodes have no expressions in them * test: split invalid test * refactor: create isImplicitlyNarrowedLiteralDeclaration function * test: add test * test: remove test
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ied name (#10697) * fix(eslint-plugin): [switch-exhaustiveness-check] suggest with qualified name * add tests * Update switch-exhaustiveness-check.ts * fix lint errors
Co-authored-by: typescript-eslint[bot] <typescript-eslint[bot]@users.noreply.github.com>
…olating type parameter in type context (#10739) * fix(eslint-plugin): [no-unnecessary-template-expression] allow type parameter * update
…rules (#10748) * remove duplicate option descriptions * also adjust consistent-type-assertions rule's docs * also apply to extension rules options * revert less straightforward changes
…10732) * fix(eslint-plugin): [prefer-nullish-coalescing] fix missing return * add tests
docs: Replace link to deprecated rule
…gnature true (#10644) * fix(eslint-plugin): [dot-notation] handle noPropertyAccessFromIndexSignature true * add test cases * add test cases * apply reviews * Add testcases
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: typescript-eslint[bot] <typescript-eslint[bot]@users.noreply.github.com>
…10728) * docs(eslint-plugin): [class-methods-use-this] refresh options docs * update docs snapshots * update snapshots * Nice, the unit tests found a mixed-up snippet * Base for ignoreOverrideMethods * test: snapshots
…n files shadowing global variables (#10710) * Ignore "declare" in definition files for no-shadow Having "declare"-tagged variables with the same name as global variables will raise an error with no-shadow even though they are types. This is a false positive due to the "declare" variables being interpreted as values during analysis. This also happens most frequently in definition files. Let's change the logic such that "declare"-tagged variables in definition files are ignored under the no-shadow rule. * Update packages/eslint-plugin/src/rules/no-shadow.ts --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…11147) * chore(deps): update dependency stylelint-config-recommended to v16 * Disable for a line with reason --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
….0 (#10966) * fix(deps): update dependency @eslint-community/eslint-utils to v4.6.1 * Merge branch 'main' --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update dependency marked to v15 * Correct docs.test.mts types * Corrected type predicate and extra test newline --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update dependency make-dir to v5 * Correct to named import --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fix(deps): update dependency ignore to v7 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fix(deps): update dependency react-markdown to v10 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fix(deps): update dependency react-resizable-panels to v2 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
fix(deps): update dependency react-resizable-panels to v3 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )