Skip to content

Refactor BST #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 27, 2020
Merged

Refactor BST #164

merged 9 commits into from
Apr 27, 2020

Conversation

ashokdey
Copy link
Member

🌲 What's Inside?

  • Added Breadth-First Search for BST
  • Re-implementation of Queue
  • Moved core BST methods logic to Utils
  • Fixes in test cases for BST
  • Moved all the test cases in a single file index.test.js

🎉

@ashokdey ashokdey requested a review from TheSTL December 17, 2019 18:37
@ashokdey ashokdey self-assigned this Dec 17, 2019
@igauravsehrawat igauravsehrawat self-requested a review February 22, 2020 12:38
igauravsehrawat
igauravsehrawat approved these changes Feb 24, 2020
View reviewed changes
Copy link

@igauravsehrawat igauravsehrawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@ashokdey
Copy link
Member Author

Thanks @igauravsehrawat, it seems like I myself forgot about this PR.
@TheSTL do look into this as well

@TheSTL TheSTL self-requested a review April 27, 2020 14:46
@ashokdey ashokdey merged commit 729aabe into master Apr 27, 2020
@ashokdey ashokdey deleted the refactor-bst branch April 27, 2020 14:58
@ashokdey ashokdey restored the refactor-bst branch September 6, 2020 15:52
@ashokdey ashokdey deleted the refactor-bst branch September 6, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSTL TheSTL Awaiting requested review from TheSTL

1 more reviewer

@igauravsehrawat igauravsehrawat igauravsehrawat approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ashokdey ashokdey

Labels
bug-fix enhancement New feature or request refactoring strict-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashokdey @igauravsehrawat @TheSTL