Replace .kscript dir with OS specific dirs (#323) #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi @meztihn! I will test the patch locally on my computer and merge it to the 4.1 branch very soon. |
aartiPl
added a commit
that referenced
this pull request
Aug 26, 2022
* Cleanup of env variables * Fixed indentation and generation of Gradle files for IntelliJ * Re-enabled idea tests * Improved runConfiguration * Support for idea project creation: correct handling for duplicated file names. * IntelliJ support fixed * Formatting of wrapper for scripts. * Fix for OsType comparison logic (#357) * build: installation tester * build: update installer.yml * build: added ability to start GitHub action build manually. * bugfix: fix for OSTYPE linux-musl which is reported on Alpine Linux. * make KOTLIN_HOME required * feature: osHandler for operations outside of Java ecosystem * feature: added nicer debug information * refactor: split of config to smaller pieces * test: split building and cleaning (faster builds for most cases) * cleanup: overall cleanups * feature: Migrated kscript to os independent paths (OsPath) * feature: KScript seems to work on a plain Windows console. * Fix #335: Get --package working with Gradle 7 by replacing the capsule plugin (#370) * Fix #335: Remove the need for the Gradle capsule plugin. * Additional fixes for packaging (better cache support) * Improved Templates.kt * Added Kotlin integration tests for packaging and simple tests * Added suites for different OSes * Renamed MAC to MACOS constant. * Fixed error in StreamGobbler in ProcessRunner * Added empty source case handling * Better implementation of OsPath.leaf and OsPath.root * Added integration tests * Improved testing tools (matchers) * Cleanup, bug fixes and small improvements. * Removed old test suite in bash * Updated TestsReadme.md * Replace .kscript dir with OS-specific dirs (#323) (#374) * Refactoring to allow deprecation. * Deprecation of old features (annotations based on comments) * Deprecation report * Updated doc. Co-authored-by: holgerbrandl@gmail.com <holgerbrandl@users.noreply.github.com> Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk> Co-authored-by: meztihn <6940823+meztihn@users.noreply.github.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated PR since I can't change the source branch.
An unrelated note, since sdkman is recommended as a package manager: it works only with bash, but IDEA starts from sh by default. This leads to a problem with missing env variables for packages installed through sdkman (e.g. gradle, kotlin). Developers of sdkman won't do antyhing about it, so the easiest workaround is to edit idea.sh and change it's shebang from sh to bash. It's pretty sneaky problem and it's description could be useful somewhere in readme for contributors.