Fix ksnip not working for multiple users on the same machine #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sobjornstad no need to credit me, thanks. |
DamirPorobic
requested changes
Aug 20, 2024
| attachDetach(); | ||
| return create(); | ||
| } | ||
| if(this->create()) |
There was a problem hiding this comment.
Can you add braces around this return.
Is "this->" here required, I think can be omitted.
| } | ||
| return false; | ||
| if(mSingular->attach()) | ||
| mSingular->detach(); |
|
|
||
| #include <iostream> | ||
| #include <unistd.h> | ||
| #include <sys/types.h> |
There was a problem hiding this comment.
Looks like some of those includes are duplicated, can be cleaned up a bit.
|
This doesn't work on Windows, actually, it breaks the windows build. |
DamirPorobic
added a commit
that referenced
this pull request
Oct 27, 2024
DamirPorobic
added a commit
that referenced
this pull request
Oct 28, 2024
DamirPorobic
added a commit
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a pull request for @m0ntana's patch here, since they have not responded to that request. The fix worked for me as well, would love to get it into upstream so I don't have to build ksnip myself everywhere I want this to work :)
Could not find @m0ntana's email to credit them, please edit committer metadata if you can