Further attempt to fix qt5 build #1106
Conversation
I'm not attempting to fix qt6 build here
|
Now this is ready to merge, as you can see by the green tick :) |
| @@ -62,6 +62,7 @@ jobs: | |||
|
|
|||
|
|
|||
| package-exe: | |||
| if: ${{ github.event_name == 'push' }} | |||
There was a problem hiding this comment.
For what do we need those guards?
There was a problem hiding this comment.
In the PR there's no access to secrets, therefore upload fails
There was a problem hiding this comment.
Though it may be a good idea to move the guards closer to upload itself. Then it'll be possible to download the build artifact from the PR even without creating the release
|
|
||
| if [[ "$QT_VERSION" == 6* ]]; then | ||
| echo "USE_QT6=yes" >> $GITHUB_ENV |
There was a problem hiding this comment.
I think we have used the convention true/false or on/off.
| host: 'linux' | ||
| install-deps: 'true' | ||
|
|
||
| - name: Install dependencies | ||
| run: sudo apt-get install extra-cmake-modules libxcb-xfixes0-dev xvfb | ||
|
|
||
| - name: Install Qt6 dependencies |
There was a problem hiding this comment.
This one is going to be installed for Gt5 and Qt6, right?
There was a problem hiding this comment.
I was going to add an "if" here, but then decided that it doesn't hurt qt5 either, and eventually qt5 build would be removed anyway...
So went with just a comment instead
|
Let's see how it works :) |
No description provided.