Plugin: Improve error handling. #13102

morguldir · 2025-03-27T22:22:06Z

What this PR does / why we need it:

kubectl exec [POD] [COMMAND] had been deprecated for 5 years, and they've just removed it now. After some gdb'ing i found the problem being stderr not going anywhere, and then i found kubernetes/kubernetes#125437

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
CVE Report (Scanner found CVE and adding report)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Before

~> go build && ./plugin  conf -n ingress-nginx -lapp.kubernetes.io/name=ingress-nginx
exit status 1

After stderr change

~> go build && ./plugin  conf -n ingress-nginx -lapp.kubernetes.io/name=ingress-nginx
error: exec [POD] [COMMAND] is not supported anymore. Use exec [POD] -- [COMMAND] instead
See 'kubectl exec -h' for help and examples

exit status 1

After

~> go build && ./plugin  conf -n ingress-nginx -lapp.kubernetes.io/name=ingress-nginx
... nginx.conf ...

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I've read the CONTRIBUTION guide
I have added unit and/or e2e tests to cover my changes.
All new and existing tests passed.

linux-foundation-easycla · 2025-03-27T22:22:10Z

The committers listed above are authorized under a signed CLA.

✅ login: morguldir / name: morguldir (ac03447, 927ff87)

k8s-ci-robot · 2025-03-27T22:22:15Z

Welcome @morguldir!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-03-27T22:22:16Z

Hi @morguldir. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2025-03-27T22:22:28Z

✅ Deploy Preview for kubernetes-ingress-nginx ready!

Name	Link
🔨 Latest commit	`ac03447`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/67e74760a961eb0008be7fcf
😎 Deploy Preview	https://deploy-preview-13102--kubernetes-ingress-nginx.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Gacko

/retitle Plugin: Improve error handling.
/triage accepted
/kind bug
/priority backlog
/lgtm

k8s-ci-robot · 2025-03-28T13:46:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, morguldir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Gacko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Gacko · 2025-03-28T13:46:07Z

/cherry-pick release-1.12

k8s-infra-cherrypick-robot · 2025-03-28T13:46:10Z

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Gacko · 2025-03-28T13:46:10Z

/cherry-pick release-1.11

k8s-infra-cherrypick-robot · 2025-03-28T13:46:13Z

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Gacko · 2025-03-28T13:47:08Z

You might need to amend your commit and force-push it, so Netlify tests get triggered again. They seem to have failed on the initial attempt and I cannot manually re-trigger them.

k8s-ci-robot · 2025-03-29T01:04:44Z

New changes are detected. LGTM label has been removed.

Gacko · 2025-03-29T07:24:14Z

Nice, thank you! I kicked the failing tests, we should be good in a few minutes.

k8s-infra-cherrypick-robot · 2025-03-29T07:27:18Z

@Gacko: new pull request created: #13112

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-infra-cherrypick-robot · 2025-03-29T07:27:54Z

@Gacko: new pull request created: #13113

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

morguldir added 2 commits March 27, 2025 23:06

Plugin: update kubectl exec cmd, the argument seperator is required now

927ff87

Plugin: print stderr when a kubectl command fails

ac03447

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 27, 2025

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 27, 2025

k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2025

k8s-ci-robot requested review from Gacko and strongjz March 27, 2025 22:22

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 27, 2025

Gacko approved these changes Mar 28, 2025

View reviewed changes

k8s-ci-robot changed the title ~~Avoid returning "exit status 1" when using the ingress-nginx kubectl plugin with newer kubectl versions~~ Plugin: Improve error handling. Mar 28, 2025

k8s-ci-robot assigned Gacko Mar 28, 2025

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Mar 28, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2025

morguldir force-pushed the plugin-fixes branch from 8e46592 to ac03447 Compare March 29, 2025 01:05

Gacko added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2025

k8s-ci-robot merged commit 6841107 into kubernetes:main Mar 29, 2025
44 checks passed

k8s-infra-cherrypick-robot mentioned this pull request Mar 29, 2025

Plugin: Improve error handling. #13112

Merged

k8s-infra-cherrypick-robot mentioned this pull request Mar 29, 2025

Plugin: Improve error handling. #13113

Merged

Plugin: Improve error handling. #13102

Plugin: Improve error handling. #13102

Uh oh!

Conversation

morguldir commented Mar 27, 2025

What this PR does / why we need it:

Types of changes

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

Uh oh!

linux-foundation-easycla bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 27, 2025

Uh oh!

k8s-ci-robot commented Mar 27, 2025

Uh oh!

netlify bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-ingress-nginx ready!

Uh oh!

Gacko left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Mar 28, 2025

Uh oh!

Gacko commented Mar 28, 2025

Uh oh!

k8s-infra-cherrypick-robot commented Mar 28, 2025

Uh oh!

Gacko commented Mar 28, 2025

Uh oh!

k8s-infra-cherrypick-robot commented Mar 28, 2025

Uh oh!

Gacko commented Mar 28, 2025

Uh oh!

k8s-ci-robot commented Mar 29, 2025

Uh oh!

Gacko commented Mar 29, 2025

Uh oh!

Uh oh!

k8s-infra-cherrypick-robot commented Mar 29, 2025

Uh oh!

k8s-infra-cherrypick-robot commented Mar 29, 2025

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Mar 27, 2025 •

edited

Loading

netlify bot commented Mar 27, 2025 •

edited

Loading