Skip to content

kubelet: multiple volumes reference one PVC in one Pod #122140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

kubelet: multiple volumes reference one PVC in one Pod #122140

wants to merge 9 commits into from

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Dec 1, 2023 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Previously, pod with multiple volumes references one PVC is stuck at ContainerCreating without any error message.
Fixing this by storing multiple OuterVolumeSpecNames per volume.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Pod can have multiple volumes reference the same PVC

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.29 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.29.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Dec 1 04:07:07 UTC 2023.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 1, 2023
@huww98 huww98 force-pushed the multi-volume-for-upstream branch from 9d0bc76 to 0214bf9 Compare December 1, 2023 07:45
@bart0sh
Copy link
Contributor

bart0sh commented Dec 8, 2023

@huww98 this sounds like a bug to me. Please cover this use case with tests, thanks.

/kind bug
/triage accepted
/priority important-soon
/ok-to-test
/cc @gnufied @jsafrane

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 8, 2023
@huww98
Copy link
Contributor Author

huww98 commented Dec 8, 2023

/remove-kind feature

@k8s-ci-robot k8s-ci-robot removed the kind/feature Categorizes issue or PR as related to a new feature. label Dec 8, 2023
@huww98 huww98 force-pushed the multi-volume-for-upstream branch from 0214bf9 to f7e52e1 Compare December 8, 2023 14:05
@huww98 huww98 force-pushed the multi-volume-for-upstream branch from 63c00ae to 6046e7c Compare November 8, 2024 03:01
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 8, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from Needs Approver to Done in SIG Node: code and documentation PRs Apr 7, 2025
huww98 added 4 commits August 2, 2025 20:28
@huww98
kubelet/volumeManager: verifyVolumesMountedFunc checks both desired a…
0913160 
…nd actual

This is intended to remove dependency on mountedVolume.OuterVolumeSpecNames
@huww98
kubelet/volumeManager: GetMountedVolumesForPod() returns desired and …
c20b105 
…actually mounted volumes

This should be fine because the volumes not in DSW should be umounted soon anyway.

Use GetPossiblyMountedVolumesForPod() for checking volumes unmounted in tests.
Production code should already using it.

This is intended to remove dependency on mountedVolume.OuterVolumeSpecNames
@huww98
kubelet/volumeManager: (Get -> Has)PossiblyMountedVolumesForPod
50fec6f 
This is intended to remove dependency on mountedVolume.OuterVolumeSpecNames
@huww98
move timeout to only cover the line under test
1d792b0 
To make the test more robust if the test runs slow.

Other goroutines are still properly cleaned up because ctx returned by ktesting.Init is automatically cancelled after test finishes.
@huww98
Copy link
Contributor Author

huww98 commented Aug 6, 2025

/reopen
/remove-lifecycle rotten
Since #128649 has been approved and queued for v1.35. I will also rebase this one on top of that PR.

@k8s-ci-robot k8s-ci-robot reopened this Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

@huww98: Reopened this PR.

In response to this:

/reopen
/remove-lifecycle rotten
Since #128649 has been approved and queued for v1.35. I will also rebase this one on top of that PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huww98, jsafrane
Once this PR has been reviewed and has the lgtm label, please ask for approval from mrunalp. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

huww98 added 3 commits August 6, 2025 10:35
@huww98
remove MountedVolume.OuterVolumeSpecNames from logs
c1f881b
@huww98
kubelet/volumeManager: remove outerVolumeSpecName from ASW
bee5826
@huww98
kubelet: multiple volumes reference one PVC in one Pod
5437577 
Previously, pod with multiple volumes references one PVC is stuck at
ContainerCreating without any error message.
Fixing this by storing multiple OuterVolumeSpecNames per volume
@huww98 huww98 force-pushed the multi-volume-for-upstream branch from 6046e7c to 12b1252 Compare August 6, 2025 02:39
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2025
huww98 added 2 commits August 6, 2025 10:48
@huww98
test: add assertion to check OuterVolumeSpecNames
5aab30c 
Also add a new case for multiple outer names.
And some small fixes to existing cases.
@huww98
e2e: case for multiple volumes reference one PVC
dd8e00f
@huww98 huww98 force-pushed the multi-volume-for-upstream branch from 12b1252 to dd8e00f Compare August 6, 2025 02:48
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 6, 2025 •
edited
Loading

@huww98: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit-windows-master dd8e00f link false /test pull-kubernetes-unit-windows-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@huww98
Copy link
Contributor Author

huww98 commented Aug 6, 2025

/test pull-kubernetes-e2e-gce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@jsafrane jsafrane Awaiting requested review from jsafrane

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mrunalp mrunalp Awaiting requested review from mrunalp

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@gnufied gnufied

@mrunalp mrunalp

@jsafrane jsafrane

Labels
area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@huww98 @k8s-ci-robot @bart0sh @jsafrane @liggitt @gnufied @k8s-triage-robot @msau42 @mrunalp @dchen1107