Disambiguate and clean up pkg/kubelet/config #123066
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tallclair The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I cleaned up the linter errors, although none were actually from this PR. |
|
/retest |
1 similar comment
|
/retest |
|
/triage accepted |
| "os" | ||
| "regexp" | ||
|
|
||
| "k8s.io/klog/v2" |
There was a problem hiding this comment.
nit: i'd move this down to k8s block.
|
/cc @bobbypage |
| @@ -14,7 +14,7 @@ See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
| */ | |||
|
|
|||
| package config | |||
There was a problem hiding this comment.
admitting, I am not good with names. Why not keep it just config?
There was a problem hiding this comment.
Do you mean why "kubeletconfig" rather than "config"? Mostly because I don't want people getting confused between the old config package, and kubelet config. And also because kubeletconfig already exists, and didn't seem like it needed changing. I'm definitely open to renaming that one though.
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @wangzhen127 |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@wangzhen127: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The package
pkg/kubelet/configwas originally intended to provide streams of pods ("pod configs", aka pod api objects) from various sources (apiserver, file, http), but the nameconfigis overloaded, and understandably people started putting files related to kubelet configuration in that directory.To disambiguate the two uses,
pkg/kubelet/configis renamed topodsource, and kubelet conifguration related code to is moved to thepkg/kubelet/kubeletconfigpackage. There are already some references to pod sources, hence the name choice.Full list of changes:
pkg/kubelet/config -> pkg/kubelet/podsourcePodConfig -> PodSource(and related symbols)ContainerRuntimeOptionstopkg/kubelet/kubeconfigContainerRuntimeOptionsflags tocmd/kubelet/app/optionsDoes this PR introduce a user-facing change?
/sig node