kubelet: support metrics configuration #123426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
7f1db4f to
0d24bcc
Compare
0d24bcc to
e141bed
Compare
|
/remove-sig api-machinery |
|
/sig instrumentation |
|
@dashpole @dgrisonnet Reiterating on our discussion from the latest SIG call, it seems there is no equivalent |
|
I'm OK proceeding without it if needed. We already have other fields that will need to be moved. But I don't think it should be that large of a change. We don't need to migrate existing fields into it this release, if that helps |
|
/triage accepted It seems there it was discussion about the rationale for this change. Could you please record it in the commit message and/or PR description? IOW, what's the benefit for "Allow users to disable metrics using the respective component-base API." ? |
|
Since we missed code freeze, we can take our time and get this in 1.31. Lets try and move to an overall metrics config during tha timeframe |
|
Tests are failing with, Looking into it. |
992d2dd to
1818769
Compare
|
/test ci-cgroupv2-containerd-node-e2e-serial-ec2 |
|
@rexagod: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-kubernetes-node-kubelet-serial-containerd |
1818769 to
9caf63e
Compare
hashim21223445
approved these changes
Apr 27, 2025
9caf63e to
e47282d
Compare
Introduce metrics API for configuring options in a non-breaking manner.
e47282d to
937f821
Compare
|
/test pull-kubernetes-node-kubelet-serial-containerd |
937f821 to
73e5b79
Compare
hashim21223445
approved these changes
May 1, 2025
Allow users to disable metrics using the respective component-base API. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
73e5b79 to
2fd0248
Compare
074c55a to
7361f20
Compare
|
/test pull-kubernetes-node-kubelet-serial-containerd |
7361f20 to
508a78e
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dashpole, rexagod The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it: Allow users to configure
k8s.io/component-base/metrics/options. This is in line with how logging and tracing options are configured currently inkubelet.Does this PR introduce a user-facing change?
Blocked by #131572.