-
Notifications
You must be signed in to change notification settings - Fork 41.3k
upgrade: upgrade dependencies github.com/prometheus/common to the newest version #124346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Apr 17 07:56:14 UTC 2024. |
Hi @jwcesign. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @liggitt Can you please take a look? Thank you. |
@dims Hi, can you help take a look about this? |
like #119312, you need run
|
@pacoxu Thanks for helping! Should I do something with this Note? root@play [21:56:01] [~/git/kubernetes] [master *]
-> # hack/update-vendor.sh
+++ [0418 21:56:50] logfile at /tmp/update-vendor.7OL2/update-vendor.log
+++ [0418 21:56:50] go.mod: update staging references
+++ [0418 21:57:11] go.mod: propagate to staging modules
+++ [0418 21:57:17] go.mod: sorting staging modules
+++ [0418 21:57:57] go.mod: tidying
+++ [0418 21:59:53] go.mod: adding generated comments
+++ [0418 21:59:55] vendor: updating internal modules
+++ [0418 22:00:47] vendor: running 'go work vendor'
+++ [0418 22:00:53] vendor: updating vendor/LICENSES
+++ [0418 22:01:03] vendor: creating OWNERS file
+++ [0418 22:01:03] NOTE: don't forget to handle vendor/* and LICENSE/* files that were added or removed |
As the note say, you can ignore it if you do not add a new dep or remove one. BTW, code block using ``` is preferred than screenshot. It's not convenient to copy-paste from a screenshot. |
/lgtm |
LGTM label has been added. Git tree hash: 10288b778cb8c80a7060888453e32a687770463c
|
/test pull-kubernetes-e2e-kind-ipv6 |
…est version Signed-off-by: jwcesign <jwcesign@gmail.com>
/cc @smarterclayton @alexzielenski |
LGTM label has been added. Git tree hash: 14fa2bacdbaf1fb6f8b22383872598b8520a678b
|
One library down :) checked the diffs, looks good to me. /approve
|
Any chance this will be cherry-picked to v1.30? |
likely not... we don't generally bump dependencies on release branches unless required for security fixes |
…est version
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I import go lib A, it needs github.com/prometheus/common@v0.48.0
And I also import k8s.io/component-base@v0.29.3(which asks for github.com/prometheus/common@v0.44.0), and the API is not compatible(0.44 ~ 0.48).
We upgrade it to solve the conflicts.
Which issue(s) this PR fixes:
Fixes #none
Special notes for your reviewer:
Realted PR: https://github.com/prometheus/common/pull/576/files#r1506321128
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: