SyncPod record error and set error status to span when return err is non-nil #125017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not nil Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
|
/ok-to-test |
|
/assign @dashpole |
|
/sig-instrumentation |
|
LGTM label has been added. Git tree hash: 0459220e1f06514f0338d278b515d0b643c87054
|
|
/priority important-longterm |
|
/sig instrumentation |
|
/assign @sjenning |
|
@sjenning Hi, do you have time to review this pr? Thanks! |
|
/triage accepted |
|
/approve given @dashpole already chimed in and change looks good to me as well. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, dims, fatsheep9146 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Our team is now using the kubelet tracing feature to calculate the successful rate of
syncPodby using otel-collector's spanmetric connector. And draw a dashboard like following graphBut we found a flaw that since the span of
syncPodis not recording error or set span status to Error when the syncPod return's non-nil error, so we could not get correct status of syncPod from span.So I suggest we change the code like following, which will RecordError and SetStatus to codes.Error when err is not nil.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: