-
Notifications
You must be signed in to change notification settings - Fork 41.1k
Separate backOff policy for static pod #126019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @llhhbc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
355f76b
to
67ab247
Compare
/ok-to-test |
I think this is an interesting feature but not sure this implementation is the right path forward. If we wanted to control BackOffzlimit for static pods I wonder if this should be an API in the pod spec.. I would consider a KEP for this as I don’t think annotations would be a good path forward. |
@kannon92 How is this planned? Is this field reflected in the pod spec? Or in priorityClassName? |
Pod spec but I think you’d want to bring this up to sig node as API changes usually require some buyin |
@kannon92 How should I submit? |
I’d suggest taking this PR to sig-node meeting and see what the consensus is. |
@kannon92 I don't know how to proceed with this? I should not have relevant permissions, can you initiate a relevant application? |
db0f65c
to
fb39754
Compare
@llhhbc please, present this on SIG-Node meeting as @kannon92 suggested, thanks. |
/hold |
@llhhbc: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: llhhbc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bart0sh Sorry, I don't know how to present this on [SIG-Node meeting] |
You just need to call into the meeting and explain your idea there. Updating agenda would be nice to do as well. |
@bart0sh I don't have the corresponding permissions. Can you help initiate the application? Thanks |
Sure, I can update meeting agenda for the next meeting on your behalf. Can you show me what to put there? Your name and a topic should be enough. Is next meeting(next Tuesday 10 AM PT) ok for you? |
@llhhbc BTW, rebasing your changes would make the PR look better. |
Most static pods run as critical components. When an exception occurs and a restart is required, the sooner the better, so a separate backoff policy is set for static pods.
fb39754
to
502715b
Compare
@bart0sh Thanks, I have rebase the commit. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@llhhbc: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Apr 14 01:30:02 UTC 2025. |
/remove-lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Most static pods run as critical components. When an exception occurs and a restart is required, the sooner the better, so a separate backoff policy is set for static pods.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: