Skip to content

Disable ServiceAccountNodeAudienceRestriction feature gate by default in v1.32 #130015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

Disable ServiceAccountNodeAudienceRestriction feature gate by default in v1.32 #130015

merged 1 commit into from
Feb 7, 2025

Conversation

aramase
Copy link
Member

@aramase aramase commented Feb 6, 2025 •
edited by liggitt
Loading 

Fixes a 1.32 regression in with the ServiceAccountNodeAudienceRestriction feature where `azureFile` volumes encounter "failed to get service accoount token attributes" errors. Reverts the `ServiceAccountNodeAudienceRestriction` feature to disabled in v1.32. Refer to https://github.com/kubernetes/kubernetes/issues/129935 for more details. If you're using in-tree inline volumes or in-tree persistent volumes whose CSI drivers depend on service account tokens, do not enable this feature in the 1.32 release.

/kind regression
/sig auth
/triage accepted
/priority important-soon

@aramase
Disable ServiceAccountNodeAudienceRestriction feature gate by default…
953ac56 
… in v1.32

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Feb 6, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/regression Categorizes issue or PR as related to a regression from a prior release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 6, 2025
@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 6, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2025
@aramase
Copy link
Member Author

aramase commented Feb 6, 2025

/assign liggitt

This was referenced Feb 6, 2025
Merged
Closed
liggitt
liggitt reviewed Feb 6, 2025
View reviewed changes
@liggitt
Copy link
Member

liggitt commented Feb 6, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 462ff95798cf24e54467cb20bbb9f95f4903a891

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@aramase
Copy link
Member Author

aramase commented Feb 6, 2025 •
edited
Loading

/cc kubernetes/release-managers

This is a cherry pick of the first commit from #130017.

@k8s-ci-robot k8s-ci-robot requested a review from a team February 6, 2025 20:22
@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Feb 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, liggitt, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 80fb77a into kubernetes:release-1.32 Feb 7, 2025
16 checks passed
@aramase aramase deleted the aramase/f/disable_serviceaccountnodeaudiencerestriction_1.32 branch February 7, 2025 14:06
dfajmon pushed a commit to dfajmon/kubernetes that referenced this pull request Feb 10, 2025
@aramase @dfajmon
UPSTREAM: <carry>: Disable ServiceAccountNodeAudienceRestriction feat…
0f441b9 
…ure gate by default in v1.32

kubernetes#130015

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@dfajmon dfajmon mentioned this pull request Feb 10, 2025
Merged
dfajmon pushed a commit to dfajmon/kubernetes that referenced this pull request Feb 11, 2025
@aramase @dfajmon
UPSTREAM: <130015>: Disable ServiceAccountNodeAudienceRestriction fea…
f820bb0 
…ture gate by default in v1.32

kubernetes#130015

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
dfajmon pushed a commit to dfajmon/kubernetes that referenced this pull request Feb 11, 2025
@aramase @dfajmon
UPSTREAM: 130015: Disable ServiceAccountNodeAudienceRestriction featu…
998efde 
…re gate by default in v1.32

kubernetes#130015

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
This was referenced Feb 16, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
4 participants
@aramase @liggitt @k8s-ci-robot @saschagrunert