[BugFix]Update ImageLocality plugin to account ImageVolume images #130231

Barakmor1 · 2025-02-18T10:12:18Z

Update ImageLocality plugin to account for ImageVolume images when scoring
and prioritizing nodes with required pod images

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

linux-foundation-easycla · 2025-02-18T10:12:22Z

The committers listed above are authorized under a signed CLA.

✅ login: Barakmor1 / name: Barak Mordehai (7dbbef8)

k8s-ci-robot · 2025-02-18T10:12:27Z

Welcome @Barakmor1!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-02-18T10:12:27Z

Hi @Barakmor1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-02-18T10:12:27Z

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

haosdent · 2025-02-19T02:24:29Z

/ok-to-test

pkg/scheduler/framework/plugins/imagelocality/image_locality.go

haosdent · 2025-02-19T02:27:39Z

pkg/scheduler/framework/plugins/imagelocality/image_locality.go

@@ -107,6 +107,13 @@ func sumImageScores(nodeInfo *framework.NodeInfo, pod *v1.Pod, totalNumNodes int
 			sum += scaledImageScore(state, totalNumNodes)
 		}
 	}
+	for _, volume := range pod.Spec.Volumes {


Not sure if should check the "ImageVolume" feature gate at here, and only account volume when it enabled.

Alright, it's done. Is there anything else missing?

None from me. Let's wait for other reviewers

Well, actually I'm not sure about this.
We may have a scheduler without this fg, but both api-server and kubelet has it enabled.
In this case, kubelet will pull the images anyway.
I prefer to calculate them anyway. /cc @macsko What's your opinion?

pkg/scheduler/framework/plugins/imagelocality/image_locality_test.go

Barakmor1 · 2025-02-24T14:46:09Z

/cc @saschagrunert

saschagrunert

Code LGTM. I somehow have issues to see that as a bug, but I assume that's up to the scheduler folks to decide that.

k8s-ci-robot · 2025-02-24T14:52:47Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Barakmor1, saschagrunert
Once this PR has been reviewed and has the lgtm label, please assign sanposhiho for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

pkg/scheduler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

AxeZhan · 2025-02-26T03:18:02Z

pkg/scheduler/framework/plugins/imagelocality/image_locality_test.go

-		nodes        []*v1.Node
-		expectedList framework.NodeScoreList
-		name         string
+		featureEnabled bool


No need to disable this featuregate when testing cases without imageVolume. Those cases should be tested to verify they works well with this fg enabled.
I think it should be ok to just enable this fg for all cases.

Wouldn't we be missing the test case that verifies everything works as expected when the feature gate is disabled?

For some test we run cases twice with fg enabled/disabled to ensure this. Like this one

kubernetes/pkg/scheduler/backend/queue/scheduling_queue_test.go

Line 1066 in 39c640f

schedulingHintsEnablement []bool

But since the influence of fg enablement is rather small here. I think it should be fine.

googs1025 · 2025-02-26T03:30:23Z

pkg/scheduler/framework/plugins/imagelocality/image_locality.go

@@ -107,6 +110,16 @@ func sumImageScores(nodeInfo *framework.NodeInfo, pod *v1.Pod, totalNumNodes int
 			sum += scaledImageScore(state, totalNumNodes)
 		}
 	}
+	if utilfeature.DefaultFeatureGate.Enabled(features.ImageVolume) {


We can use the feature of the pkg/scheduler/framework/plugins/feature/feature.go package to avoid using DefaultFeatureGate.Enabled directly

FYI:
#130414

Barakmor1 · 2025-02-26T07:14:25Z

Hi, I'll address the comments once we reach agreement on this comment. I'm new to this repository, so any advice on how we can move forward would be appreciated. :)

k8s-triage-robot · 2025-05-27T08:19:57Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Barakmor1 · 2025-05-27T11:25:28Z

/remove-lifecycle stale

Barakmor1 · 2025-08-07T07:42:18Z

I removed the FeatureGate status logic, as ImageVolume is expected to GA in Kubernetes 1.35.
I’ll resume this work once GA is confirmed.

/hold

to account for ImageVolume images when scoring and prioritizing nodes with required pod images Signed-off-by: bmordeha <bmordeha@redhat.com>

k8s-ci-robot · 2025-08-07T10:49:04Z

@Barakmor1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-cmd	`7dbbef8`	link	true	`/test pull-kubernetes-cmd`
pull-kubernetes-e2e-kind	`7dbbef8`	link	true	`/test pull-kubernetes-e2e-kind`
pull-kubernetes-conformance-kind-ga-only-parallel	`7dbbef8`	link	true	`/test pull-kubernetes-conformance-kind-ga-only-parallel`
pull-kubernetes-e2e-gce	`7dbbef8`	link	true	`/test pull-kubernetes-e2e-gce`
pull-kubernetes-verify	`7dbbef8`	link	true	`/test pull-kubernetes-verify`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2025

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 18, 2025

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 18, 2025

k8s-ci-robot requested review from AxeZhan and macsko February 18, 2025 10:12

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2025

haosdent reviewed Feb 19, 2025

View reviewed changes

Barakmor1 force-pushed the updateimagelocality branch from 3b46843 to 4dd2cba Compare February 19, 2025 07:59

This was referenced Feb 24, 2025

[BugFix]Allow ImageVolume for Restricted PSA profiles #130394

Merged

[POC]Use ImageVolume instead of container disk kubevirt/kubevirt#13656

Closed

VolumeSource: OCI Artifact and/or Image kubernetes/enhancements#4639

Open

Barakmor1 force-pushed the updateimagelocality branch 3 times, most recently from 3edd74c to a9ec924 Compare February 24, 2025 14:44

k8s-ci-robot requested a review from saschagrunert February 24, 2025 14:46

saschagrunert approved these changes Feb 24, 2025

View reviewed changes

Barakmor1 force-pushed the updateimagelocality branch from a9ec924 to 1e467ca Compare February 25, 2025 09:06

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2025

AxeZhan reviewed Feb 26, 2025

View reviewed changes

googs1025 reviewed Feb 26, 2025

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2025

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 27, 2025

Barakmor1 force-pushed the updateimagelocality branch from 1e467ca to c8aaa02 Compare August 7, 2025 07:27

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 7, 2025

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2025

Update imageLocality plugin

7dbbef8

to account for ImageVolume images when scoring and prioritizing nodes with required pod images Signed-off-by: bmordeha <bmordeha@redhat.com>

Barakmor1 force-pushed the updateimagelocality branch from c8aaa02 to 7dbbef8 Compare August 7, 2025 08:29

[BugFix]Update ImageLocality plugin to account ImageVolume images #130231

Are you sure you want to change the base?

[BugFix]Update ImageLocality plugin to account ImageVolume images #130231

Uh oh!

Conversation

Barakmor1 commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

linux-foundation-easycla bot commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 18, 2025

Uh oh!

k8s-ci-robot commented Feb 18, 2025

Uh oh!

k8s-ci-robot commented Feb 18, 2025

Uh oh!

haosdent commented Feb 19, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Barakmor1 commented Feb 24, 2025

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Barakmor1 commented Feb 26, 2025

Uh oh!

k8s-triage-robot commented May 27, 2025

Uh oh!

Barakmor1 commented May 27, 2025

Uh oh!

Barakmor1 commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Aug 7, 2025

Uh oh!

Uh oh!

Barakmor1 commented Feb 18, 2025 •

edited

Loading

linux-foundation-easycla bot commented Feb 18, 2025 •

edited

Loading

Barakmor1 commented Aug 7, 2025 •

edited

Loading