Skip to content

bump k8s.io/utils for improvements #130995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

bump k8s.io/utils for improvements #130995

merged 1 commit into from
Apr 23, 2025

Conversation

xigang
Copy link
Member

@xigang xigang commented Mar 22, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR bumps k8s.io/utils to include new Len() and Cap() methods for Informer metrics. These methods help calculate numberOfPendingNotifications and sizeOfRingGrowing, improving observability of the informer event queue.

Related Enhancements
KEP: Informer Metrics

Relevant Code Changes

type eventHandlerMetrics struct {
  // Number of pending notifications in the event queue
  numberOfPendingNotifications GaugeMetric

  // Size of the growing ring buffer
  sizeOfRingGrowing GaugeMetric

  // Duration to process an item from the informer reflector
  processDuration HistogramMetric
}

Related PRs

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 22, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @xigang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 22, 2025
@k8s-ci-robot k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Mar 22, 2025
@k8s-ci-robot k8s-ci-robot requested review from andyzhangx, ardaguclu and a team March 22, 2025 02:26
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Auth Mar 22, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Mar 22, 2025
@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Mar 22, 2025
@xigang
Copy link
Member Author

xigang commented Mar 22, 2025

/cc @wojtek-t @soltysh

@xigang
Copy link
Member Author

xigang commented Mar 24, 2025 •
edited
Loading

friendly ping @wojtek-t @liggitt Could you help review? The Informer Metrics feature needs to rebase this PR.

@liggitt
Copy link
Member

liggitt commented Mar 24, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d470aa7a9863a665f634746c6703de6f5937e838

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, xigang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2025
@xigang
Copy link
Member Author

xigang commented Mar 25, 2025 •
edited
Loading

@liggitt @wojtek-t @dims also need a label for milestone v1.33.

@wojtek-t
Copy link
Member

We're in code freeze now, so that needs to wait...

@xigang
Copy link
Member Author

xigang commented Mar 25, 2025

We're in code freeze now, so that needs to wait...

Okay. Thanks for the reply.

@dims dims removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 25, 2025
@bart0sh bart0sh moved this from Triage to not-only-sig-node in SIG Node: code and documentation PRs Mar 25, 2025
@seans3
Copy link
Contributor

seans3 commented Mar 25, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 25, 2025
@liggitt liggitt added this to the v1.34 milestone Apr 1, 2025
@xigang xigang mentioned this pull request Apr 3, 2025
Open
@k8s-ci-robot k8s-ci-robot merged commit 43a7d3b into kubernetes:master Apr 23, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from not-only-sig-node to Done in SIG Node: code and documentation PRs Apr 23, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG CLI Apr 23, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Closed / Done in SIG Auth Apr 23, 2025
@xigang xigang mentioned this pull request Apr 26, 2025
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@soltysh soltysh Awaiting requested review from soltysh

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Archived in project
SIG Auth
Archived in project
SIG CLI
Archived in project
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
6 participants
@xigang @k8s-ci-robot @liggitt @wojtek-t @seans3 @dims