Skip to content

Update hpa OWNERS #131292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update hpa OWNERS #131292

wants to merge 1 commit into from

Conversation

raywainman
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Refreshes the list of HPA reviewers and approvers, per #128948.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 14, 2025
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.33 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.33.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Apr 14 13:34:58 UTC 2025.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 14, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raywainman
Once this PR has been reviewed and has the lgtm label, please assign mwielgus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 14, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Apr 14, 2025
@raywainman raywainman mentioned this pull request Apr 14, 2025
Open
@raywainman
Copy link
Member Author

/assign soltysh

soltysh
soltysh reviewed Apr 29, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
until I get confirmation that the new reviewers meet the necessary requirements

pkg/controller/podautoscaler/OWNERS
- gjtempleton
- mwielgus
- omerap12
- raywainman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I've stated in the linked issue, the maintainers need to earn their respective status. For the above 3 reviewers can you link me here the required number of PRs so that I can confirm they are eligible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed: #131650

pkg/controller/podautoscaler/OWNERS
approvers:
- mwielgus
- gjtempleton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked with Guy about it, he's not there yet meeting the approver requirements, so this can't be modified yet.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2025
@omerap12 omerap12 mentioned this pull request Apr 29, 2025
Merged
@soltysh soltysh mentioned this pull request May 8, 2025
Merged
@raywainman
Copy link
Member Author

Closing this in favor of #131650, thanks all.

@raywainman raywainman closed this May 8, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Closed in SIG Apps May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@soltysh soltysh

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Apps
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raywainman @k8s-ci-robot @soltysh @BenTheElder