Skip to content

chore: move watch handler tests to handlers pkg #131323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

chore: move watch handler tests to handlers pkg #131323

merged 1 commit into from
Apr 24, 2025

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented Apr 15, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it

  • Move the watch handler unit tests to the same package as the WatchServer implementation. k8s.io/apiserver/pkg/endpoints -> k8s.io/apiserver/endpoints/handlers
  • Copy over minimal scheme and codec test setup
  • Refactor the tests to use testify assert and require

This unblocks making WatchServer private, if we decide to do that.

Does this PR introduce a user-facing change?

NONE

Blocking

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 15, 2025
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.33 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.33.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Apr 15 19:35:15 UTC 2025.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 15, 2025
@karlkfi
chore: move watch handler tests to handlers pkg
7fcc1bc 
- Move the watch handler unit tests to the same package as the
  WatchServer implementation.
  k8s.io/apiserver/pkg/endpoints -> k8s.io/apiserver/endpoints/handlers
- Copy over minimal scheme and codec test setup
- Refactor the tests to use testify assert and require

This unblocks making WatchServer private, if we decide to do that.
@karlkfi karlkfi force-pushed the karl-watch-test-move branch from 6b8a4df to 7fcc1bc Compare April 16, 2025 00:23
@karlkfi karlkfi mentioned this pull request Apr 17, 2025
Open
@karlkfi
Copy link
Contributor Author

karlkfi commented Apr 17, 2025

/assign @wojtek-t

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e66c657fc14e10c7c1925d84d63ee6e3e126dd59

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2025
@cici37
Copy link
Contributor

cici37 commented Apr 17, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 360a3bf into kubernetes:master Apr 24, 2025
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Apr 24, 2025
@karlkfi karlkfi deleted the karl-watch-test-move branch April 24, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@sttts sttts Awaiting requested review from sttts

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
4 participants
@karlkfi @k8s-ci-robot @wojtek-t @cici37