Skip to content

[WIP][FG:InPlacePodVerticalScaling] Remove CPUs based on the mustKeepCpus which get from container by function RunInContainer #131331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[WIP][FG:InPlacePodVerticalScaling] Remove CPUs based on the mustKeepCpus which get from container by function RunInContainer #131331

wants to merge 9 commits into from
+5,070 −138

Conversation

Chunxia202410
Copy link

@Chunxia202410 Chunxia202410 commented Apr 16, 2025 •
edited
Loading

What type of PR is this?
/kind bug
/kind api-change

What this PR does / why we need it:
This is a potential solution for issue #131309

kubelet get the mustKeepCpus from container by function RunInContainer, and the mustKeepCpus should include the promised CPUs in checkpoint.
promised CPUs in checkpoint implement in #129719.
image

Which issue(s) this PR fixes:
Fixes ##131309

Special notes for your reviewer:
The implement for this PR is in commit 8c6025d.
Please ignore the change in pod_resize_test.go

Does this PR introduce a user-facing change?
NONE

esotsal and others added 9 commits April 4, 2025 10:11
@esotsal
Static CPU management policy alongside InPlacePodVerticalScaling
1d92a54
@Chunxia202410 @esotsal
Support InPlacePodVerticalScaling for Static CPU management policy
38944df
@esotsal
Fix go fmt isssues
fe6c97f
@esotsal
Fix mutation heuristic check of mustKeepCPUs, reason is clone
6b5333e
@esotsal
Fix glangci-lint-pr failed test
1d8187c
@esotsal
Fix compile issue, due to update in e2e/framework removing rollback bool
73998dc
@esotsal
Fix compile issue and address review comment.
4eadf93 
Use new topology.Allocation struct (a CPU set plus
alignment metadata) instead of CPU set, due to rebase.

Remove duplicate unecessary SetDefaultCPUSet call as per
review comment.
@esotsal
Address sig-node meeting comments for mustKeepCPUs.
7c03d97 
- Revert introduction of API env mustKeepCPUs
- Replace mustKeepCPUs with local checkpoint "promised"
- Introduce "promised" in CPUManagerCheckpointV3 format
- Add logic, refactor with Beta candidate
- TODO improve alogn resize tests, go through testing, corner cases
- TODO improve CPUManagerCheckpointV3 tests
- TODO address code review/feedback
@Chunxia202410
Use RunInContainer to get the mustKeepCPUs
8c6025d
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2025
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 16, 2025
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.33 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.33.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Apr 16 07:35:16 UTC 2025.

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 16, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 16, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Chunxia202410. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Apr 16, 2025
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Apr 16, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Apr 16, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Chunxia202410
Once this PR has been reviewed and has the lgtm label, please assign sjenning, thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from dims and feiskyer April 16, 2025 08:11
@Chunxia202410 Chunxia202410 mentioned this pull request Apr 16, 2025
Open
@esotsal
Copy link
Contributor

esotsal commented Apr 16, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 16, 2025
@esotsal
Copy link
Contributor

esotsal commented Apr 16, 2025

/cc

@k8s-ci-robot k8s-ci-robot requested a review from esotsal April 16, 2025 13:53
@k8s-ci-robot
Copy link
Contributor

@Chunxia202410: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-typecheck 8c6025d link true /test pull-kubernetes-typecheck
pull-kubernetes-cmd 8c6025d link true /test pull-kubernetes-cmd
pull-kubernetes-e2e-gce 8c6025d link true /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-kind 8c6025d link true /test pull-kubernetes-e2e-kind
pull-kubernetes-e2e-kind-ipv6 8c6025d link true /test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-conformance-kind-ga-only-parallel 8c6025d link true /test pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-node-e2e-containerd 8c6025d link true /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2 8c6025d link false /test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2
pull-kubernetes-linter-hints 8c6025d link false /test pull-kubernetes-linter-hints
pull-kubernetes-unit-windows-master 8c6025d link false /test pull-kubernetes-unit-windows-master
pull-kubernetes-unit 8c6025d link true /test pull-kubernetes-unit
pull-kubernetes-integration 8c6025d link true /test pull-kubernetes-integration
pull-kubernetes-verify 8c6025d link true /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Chunxia202410 Chunxia202410 mentioned this pull request Apr 17, 2025
Open
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Apr 23, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dims dims added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 12, 2025
@bart0sh bart0sh moved this from Triage to Work in progress in SIG Node: code and documentation PRs Jul 14, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashim21223445 hashim21223445 hashim21223445 approved these changes

@dims dims Awaiting requested review from dims

@feiskyer feiskyer Awaiting requested review from feiskyer

@esotsal esotsal Awaiting requested review from esotsal

Assignees
No one assigned
Labels
area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
SIG Apps
Status: Needs Triage
SIG Node CI/Test Board
Status: Archive-it
SIG Node: In Place Pod Vertical Scaling
Status: No status
SIG Node: code and documentation PRs
Status: Work in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Chunxia202410 @k8s-ci-robot @esotsal @k8s-triage-robot @hashim21223445 @dims