Skip to content

Clean up pkg/kubelet/config #131483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clean up pkg/kubelet/config #131483

wants to merge 2 commits into from
+61 −64

Conversation

tallclair
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

pkg/kubelet/config holds the code for sourcing pod "config" (aka manifests), but due to the overloaded name, code related to configuring the Kubelet has slipped in. This PR moves the code that isn't related to pod config sources out of the pkg/kubelet/config package and to more appropriate locations.

Special notes for your reviewer:

This PR has the first two commits from #123066, which also renamed the config package to podsource. I may still do that in a follow-up PR, but am trying to keep the change smaller for now.

Does this PR introduce a user-facing change?

NONE

/sig node
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 25, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 25, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tallclair
Copy link
Member Author

/assign @lauralorenz

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Apr 25, 2025
@tallclair tallclair changed the title Kubeletconfig Clean up pkg/kubelet/config Apr 25, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2025
@natasha41575
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e01bac558e6f8723aa3f0a73828a0fe732bf79f

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Needs Approver in SIG Node: code and documentation PRs May 31, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2025
@tallclair
Copy link
Member Author

@natasha41575 thanks for the review. I needed to rebase, but the changes were trivial (variable rename from be6807e)

PTAL

@natasha41575
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c3e53da1c4734d544223d095c61ca0aacc7cea8e

@tallclair
Copy link
Member Author

/assign @msau42
For storage approval (just a trivial package rename for a few constants)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot requested a review from msau42 August 6, 2025 19:12
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tallclair
Once this PR has been reviewed and has the lgtm label, please ask for approval from msau42. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@tallclair: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit bd90011 link true /test pull-kubernetes-unit
pull-kubernetes-unit-windows-master bd90011 link false /test pull-kubernetes-unit-windows-master
pull-kubernetes-integration bd90011 link true /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashim21223445 hashim21223445 hashim21223445 approved these changes

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@klueska klueska Awaiting requested review from klueska

@lauralorenz lauralorenz Awaiting requested review from lauralorenz

@natasha41575 natasha41575 Awaiting requested review from natasha41575

@msau42 msau42 Awaiting requested review from msau42

Assignees

@lauralorenz lauralorenz

@natasha41575 natasha41575

@msau42 msau42

Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Status: Needs Approver
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tallclair @k8s-ci-robot @natasha41575 @hashim21223445 @lauralorenz @msau42