Skip to content

component-base: introduce metrics api #131572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

component-base: introduce metrics api #131572

wants to merge 1 commit into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented May 1, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Introduce metrics API for configuring options in components in a non-breaking manner.

Special notes for your reviewer:

This has been branched out from #123426, as its own effort, and blocks that PR currently.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

The metrics (`k8s.io/component-base/metrics/`) API allows for leveraging its options in components in a non-breaking manner. Components are expected to incorporate this, over time, to offer more customizability to the users in terms of their overall observability experience on a per-component level.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2025
@rexagod rexagod mentioned this pull request May 1, 2025
Open
@dims
Copy link
Member

dims commented May 4, 2025

does this need API review?

@rexagod
Copy link
Member Author

rexagod commented May 15, 2025

@dims There's some outstanding changes I've planned to get in here, will keep this thread posted once its ready for API review. Moving to draft now.

@rexagod rexagod marked this pull request as draft May 15, 2025 16:46
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2025
@rexagod rexagod marked this pull request as ready for review July 26, 2025 08:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2025
@rexagod
component-base: introduce metrics api
b9572ad 
Introduce metrics API for configuring options.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod
Copy link
Member Author

rexagod commented Jul 26, 2025

@dims Apologies for the delay here, this seems fine for API review.

Also, please note that the commit used here is cherry-picked from #123426.

@rexagod
Copy link
Member Author

rexagod commented Aug 6, 2025

Bumping!

@dgrisonnet
Copy link
Member

Assigning myself for instrumentation review.

/assign
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 7, 2025
@dgrisonnet
Copy link
Member

Adding the label to get some eyes on the PR from API reviewers.

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashim21223445 hashim21223445 hashim21223445 approved these changes

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@logicalhan logicalhan Awaiting requested review from logicalhan

@richabanker richabanker Awaiting requested review from richabanker

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@dgrisonnet dgrisonnet

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rexagod @k8s-ci-robot @dims @dgrisonnet @hashim21223445