Skip to content

Add namespace-aware orphan pod indexing for improved controller performance #132400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2025
Merged

Add namespace-aware orphan pod indexing for improved controller performance #132400

merged 1 commit into from
Jun 21, 2025

Conversation

xigang
Copy link
Member

@xigang xigang commented Jun 19, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Follow-up from #132305 (comment)

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@xigang
Add namespace-aware orphan pod indexing
66c6111 
Signed-off-by: xigang <wangxigang2014@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 19, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 19, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Jun 19, 2025
@xigang
Copy link
Member Author

xigang commented Jun 19, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 19, 2025
@xigang
Copy link
Member Author

xigang commented Jun 19, 2025

cc @wojtek-t @mimowo @atiratree @hakuna-matatah

@hakuna-matatah
Copy link
Contributor

+1 on the improvement for Orphan pods - thanks for picking this up @xigang

@xigang
Copy link
Member Author

xigang commented Jun 20, 2025 •
edited
Loading

/cc @wojtek-t @mimowo @atiratree PTAL. Thanks!

@mimowo
Copy link
Contributor

mimowo commented Jun 20, 2025

ack, on it

mimowo
mimowo reviewed Jun 20, 2025
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks 👍
In a follow up I would also like to commonize the getJobPodsByIndexer functions into controller_utils.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c827ce3f94ab429ff0c847abf7fda82fa36485fe

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t, xigang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2025
@xigang
Copy link
Member Author

xigang commented Jun 21, 2025

/test pull-kubernetes-unit

@k8s-ci-robot k8s-ci-robot merged commit ccf291b into kubernetes:master Jun 21, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 21, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Apps Jun 21, 2025
@xigang xigang mentioned this pull request Jun 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@kow3ns kow3ns Awaiting requested review from kow3ns

@atiratree atiratree Awaiting requested review from atiratree

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@mimowo mimowo

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Apps
Archived in project
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
5 participants
@xigang @k8s-ci-robot @hakuna-matatah @mimowo @wojtek-t