Skip to content

scheduler_perf: remove outdated TODO comments #133080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

scheduler_perf: remove outdated TODO comments #133080

wants to merge 1 commit into from
+4 −6

Conversation

togettoyou
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

These TODOs are no longer relevant and can be safely cleaned up.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 19, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 19, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @togettoyou. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: togettoyou
Once this PR has been reviewed and has the lgtm label, please assign macsko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from AxeZhan and kerthcet July 19, 2025 15:02
@k8s-ci-robot k8s-ci-robot added area/test sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 19, 2025
@togettoyou
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2025
@macsko
Copy link
Member

macsko commented Aug 7, 2025

We should avoid merging trivial edits, because often the file(s) have more places that could be improved in one PR. Please try to find more. For example, this comment should be changed, because now startCollectingMetricsOp together with stopCollectingMetricsOp can collect metrics as well.

https://www.kubernetes.dev/docs/guide/pull-requests/#trivial-edits

@togettoyou
Copy link
Member Author

We should avoid merging trivial edits, because often the file(s) have more places that could be improved in one PR. Please try to find more. For example, this comment should be changed, because now startCollectingMetricsOp together with stopCollectingMetricsOp can collect metrics as well.

https://www.kubernetes.dev/docs/guide/pull-requests/#trivial-edits

Thank you very much for your kind reminder. I’ll keep it in mind.

I’ll check it later.

@togettoyou togettoyou force-pushed the cleanup-scheduler_perf_TODO branch from 85a1960 to 7b64298 Compare August 12, 2025 08:38
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2025
@macsko
Copy link
Member

macsko commented Aug 12, 2025

I see there is also an outdated comment of WorkloadTemplate field - it mentions a few ops, but there are much more now. Maybe we don't need to enumerate them.
Also, twice in the comments there is a "schedyling" typo.

Maybe you could try to run some tool to make sure we didn't miss any typo. Other files in scheduler_perf directory might also be worth checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AxeZhan AxeZhan Awaiting requested review from AxeZhan

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees
No one assigned
Labels
area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@togettoyou @k8s-ci-robot @macsko