Skip to content

scheduler_perf: remove outdated TODO comments #133080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −6
Open

scheduler_perf: remove outdated TODO comments #133080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions test/integration/scheduler_perf/scheduler_perf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ func (w *workload) setDefaults(testCaseThresholdMetricSelector *thresholdMetricS
w.ThresholdMetricSelector = testCaseThresholdMetricSelector
return
}
// By defult, SchedulingThroughput should be compared with the threshold.
// By default, SchedulingThroughput should be compared with the threshold.
w.ThresholdMetricSelector = &thresholdMetricSelector{
Name: "SchedulingThroughput",
}
Expand Down Expand Up @@ -542,7 +542,7 @@ type realOp interface {
patchParams(w *workload) (realOp, error)
}

// runnableOp is an interface implemented by some operations. It makes it posssible
// runnableOp is an interface implemented by some operations. It makes it possible
// to execute the operation without having to add separate code into runWorkload.
type runnableOp interface {
realOp
Expand Down Expand Up @@ -1203,9 +1203,6 @@ func RunBenchmarkPerfScheduling(b *testing.B, configFile string, topicName strin
featureGates := featureGatesMerge(tc.FeatureGates, w.FeatureGates)
informerFactory, tCtx := setupTestCase(b, tc, featureGates, outOfTreePluginRegistry)

// TODO(#93795): make sure each workload within a test case has a unique
// name? The name is used to identify the stats in benchmark reports.
// TODO(#94404): check for unused template parameters? Probably a typo.
err := w.isValid(tc.MetricsCollectorConfig)
if err != nil {
b.Fatalf("workload %s is not valid: %v", w.Name, err)
Expand Down Expand Up @@ -2324,7 +2321,8 @@ func validateTestCases(testCases []*testCase) error {
return fmt.Errorf("%s: no ops defined", tc.Name)
}
// Make sure there's at least one CreatePods op with collectMetrics set to
// true in each workload. What's the point of running a performance
// true, or a startCollectingMetricsOp together with stopCollectingMetricsOp
// in each workload. What's the point of running a performance
// benchmark if no statistics are collected for reporting?
if !tc.collectsMetrics() {
return fmt.Errorf("%s: no op in the workload template collects metrics", tc.Name)
Expand Down