Skip to content

make admission and pod-security-admission checks be informed by emulation version #133178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

make admission and pod-security-admission checks be informed by emulation version #133178

wants to merge 3 commits into from

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 24, 2025 •
edited
Loading

/sig auth api-machinery
/kind feature
xref #125271 (comment)

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 24, 2025
@liggitt liggitt added this to the v1.35 milestone Jul 24, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 24, 2025
@k8s-ci-robot k8s-ci-robot requested review from cici37 and deads2k July 24, 2025 15:23
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Jul 24, 2025
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 24, 2025
@liggitt liggitt mentioned this pull request Jul 24, 2025
Merged
@enj enj moved this to Needs Triage in SIG Auth Jul 25, 2025
@liggitt liggitt changed the title WIP - make admission and pod-security-admission checks be informed by emulation version make admission and pod-security-admission checks be informed by emulation version Jul 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 28, 2025
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 28, 2025
@liggitt liggitt added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jul 28, 2025
@k8s-ci-robot k8s-ci-robot removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 28, 2025
@liggitt liggitt marked this pull request as ready for review July 28, 2025 21:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2025
@k8s-ci-robot k8s-ci-robot requested review from aojea and cheftako July 28, 2025 21:16
@liggitt
Copy link
Member Author

liggitt commented Jul 28, 2025

This is ready for review

/milestone v1.35

@liggitt
Copy link
Member Author

liggitt commented Jul 28, 2025

/assign @jpbetz
for review or routing

@aramase aramase moved this from Needs Triage to In Review in SIG Auth Aug 4, 2025
@liggitt
Copy link
Member Author

liggitt commented Aug 5, 2025

/retest

@liggitt
Copy link
Member Author

liggitt commented Aug 5, 2025

flake on #133302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cici37 cici37 Awaiting requested review from cici37

@deads2k deads2k Awaiting requested review from deads2k

@aojea aojea Awaiting requested review from aojea

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Status: In Review
Milestone
v1.35
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @k8s-ci-robot @jpbetz