Add remote runtime/image Close() API
#133211
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6655ffb to
a1f0930
Compare
c1fde2e to
02452c2
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
kubeadm also creates the connections to the image service
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/util/runtime/runtime.go#L87
kubeadm is not a service (like kubelet), so are we OK to not close the few connections which kubeadm creates? if they timeout after a while maybe that's fine, but maybe it's a better practice to explicitly close them.
~/go/src/k8s.io/kubernetes/cmd/kubeadm$ grep containerRuntime.Connect * -rnI
app/util/runtime/runtime_test.go:69: err := containerRuntime.Connect()
app/cmd/config.go:387: if err := containerRuntime.Connect(); err != nil {
app/cmd/phases/reset/cleanupnode.go:138: if err := containerRuntime.Connect(); err != nil {
app/preflight/checks.go:1048: if err := containerRuntime.Connect(); err != nil {
app/preflight/checks.go:1087: if err := containerRuntime.Connect(); err != nil {
|
/retest |
The API allows to shutdown the internal gRPC connection to avoid leaking resources. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
02452c2 to
dae7496
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
The API allows to shutdown the internal gRPC connection to avoid leaking resources.
Which issue(s) this PR is related to:
Fixes #133183
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: